Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow semantic versioning in mypy version pins #96

Closed
Daverball opened this issue Mar 23, 2023 · 4 comments · Fixed by #97
Closed

Follow semantic versioning in mypy version pins #96

Daverball opened this issue Mar 23, 2023 · 4 comments · Fixed by #97

Comments

@Daverball
Copy link

I think until mypy reached 1.0.0 it was a fine policy to pin to the mypy version that was released at the time, since the plugin system is not guaranteed to be stable and the version numbering was sort of semantic, but not really, since it used number digits rather, than numbers separated by dots.

But now that mypy is following semantic versioning rules I think you should consider only pinning the mypy version to before the next minor version, so if the current version was 1.0.0, you would pin to <1.1.0, rather than ==1.0.0, so patch releases, like 1.0.1, which will often contain important bug fixes can still be installed without having to force ignore the version pin.

@kedder
Copy link
Member

kedder commented Mar 23, 2023

I agree. Let's try that. I'll update the pin and make a release.

@Daverball
Copy link
Author

I realize I didn't state it explicitly, but it probably still makes sense to pin the minimum version too, so people get at least the mypy version the release was tested with, but possibly a newer patch version, when available, i.e. for a release that was tested against 1.0.0 the requirement would be >= 1.0.0, <1.1.0

@kedder
Copy link
Member

kedder commented Mar 23, 2023

Yeah, that's exactly what I'm planning to do.

@kedder
Copy link
Member

kedder commented Mar 24, 2023

mypy-zope-0.9.1 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants