Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Semantic-Org/Semantic-UI-React
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.82.3
Choose a base ref
...
head repository: Semantic-Org/Semantic-UI-React
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.82.4
Choose a head ref
  • 15 commits
  • 71 files changed
  • 6 contributors

Commits on Aug 22, 2018

  1. Copy the full SHA
    058394c View commit details

Commits on Aug 25, 2018

  1. Copy the full SHA
    33dae84 View commit details
  2. fix(docs): fix issues with local builds (#3098)

    Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
    layershifter authored and levithomason committed Aug 25, 2018
    Copy the full SHA
    1ae2781 View commit details

Commits on Sep 4, 2018

  1. fix(Dropdown): override onChange in DropdownSearchInput (#3123)

    fix(Dropdown): override onChange in DropdownSearchInput
    layershifter authored Sep 4, 2018
    Copy the full SHA
    ac7cd79 View commit details
  2. feat(List): allow overriding role prop (#3125)

    feat(List): allow overriding role prop
    johannao76 authored and levithomason committed Sep 4, 2018
    Copy the full SHA
    49955ac View commit details

Commits on Sep 5, 2018

  1. Copy the full SHA
    bdce24a View commit details
  2. chore(package): update Babel 7 (#3129)

    chore(package): update Babel 7
    layershifter authored Sep 5, 2018
    Copy the full SHA
    24d4334 View commit details
  3. chore(package): update deps (#3131)

    chore(package): update deps
    layershifter authored Sep 5, 2018
    Copy the full SHA
    4d0688a View commit details

Commits on Sep 10, 2018

  1. fix(customPropTypes): allow to pass an object to "as" (#3139)

    * Allows having JSX elements as an "as" property
    
    See #3138 for the problem described. 
    Solves problem when custom links are used
    
    * update order
    tomitrescak authored and layershifter committed Sep 10, 2018
    Copy the full SHA
    9d36af3 View commit details
  2. Copy the full SHA
    bfb6799 View commit details
  3. Copy the full SHA
    bf8adb8 View commit details
  4. fix(Dropdown): fix deepEqual bug (#3104)

    * Fix dropdown deep equal bug
    
    * docs(Dropdown): link issue to fix
    pedromtorres authored and levithomason committed Sep 10, 2018
    Copy the full SHA
    f04d218 View commit details
  5. fix(EventStack): fix compatibility with IE11 (#3124)

    * fix(EventStack): fix compatibility with IE11
    
    Signed-off-by: Oleksandr Fediashov <ofediashov@exadel.com>
    
    * final refactor of eventStack
    
    * add missing perf test [ci skip]
    
    * continue refactor
    
    * move eventStack
    layershifter authored and levithomason committed Sep 10, 2018
    Copy the full SHA
    b5c76fb View commit details
  6. fix(Popup): missing CSS style update (#3109)

    * fix(Popup): missing CSS style update
    
    fixes #3050
    
    * fix(Popup): correct typos
    
    * fix(Popup): increase test coverage
    pferreir authored and levithomason committed Sep 10, 2018
    Copy the full SHA
    01ef927 View commit details
  7. 0.82.4

    levithomason committed Sep 10, 2018
    Copy the full SHA
    f20c985 View commit details
Showing with 1,237 additions and 2,576 deletions.
  1. +5 −5 .github/stale.yml
  2. +16 −13 CHANGELOG.md
  3. +1 −1 README.md
  4. +0 −1 config.js
  5. +9 −5 docs/src/components/ComponentDoc/ComponentExample/ComponentExample.js
  6. +1 −1 docs/src/components/ComponentDoc/ComponentExample/ComponentExampleRenderEditor.js
  7. +1 −1 docs/src/components/ComponentDoc/ComponentExample/ComponentExampleRenderHtml.js
  8. +4 −0 docs/src/utils/formatCode.js
  9. +0 −1 docs/src/utils/index.js
  10. +6 −11 gulp/plugins/gulp-example-source.js
  11. +27 −10 gulp/tasks/docs.js
  12. +42 −41 package.json
  13. +3 −3 src/elements/List/List.js
  14. +4 −4 src/elements/List/ListItem.js
  15. +1 −1 src/lib/customPropTypes.js
  16. +0 −84 src/lib/eventStack/EventPool.js
  17. +0 −65 src/lib/eventStack/EventSet.js
  18. +0 −70 src/lib/eventStack/EventStack.js
  19. +0 −97 src/lib/eventStack/EventTarget.js
  20. +1 −55 src/lib/eventStack/README.md
  21. +2 −4 src/lib/eventStack/index.js
  22. +0 −5 src/lib/eventStack/normalizeHandlers.js
  23. +0 −13 src/lib/eventStack/normalizeTarget.js
  24. +17 −2 src/modules/Dropdown/Dropdown.js
  25. +11 −0 src/modules/Popup/Popup.js
  26. +1 −0 static.webpack.js
  27. +2 −0 test/specs/addons/Confirm/Confirm-test.js
  28. +6 −1 test/specs/addons/Portal/Portal-test.js
  29. +6 −1 test/specs/behaviors/Visibility/Visibility-test.js
  30. +2 −2 test/specs/collections/Breadcrumb/BreadcrumbDivider-test.js
  31. +6 −7 test/specs/collections/Form/FormField-test.js
  32. +9 −17 test/specs/collections/Menu/MenuItem-test.js
  33. +4 −1 test/specs/collections/Message/Message-test.js
  34. +7 −0 test/specs/commonTests/implementsCommonProps.js
  35. +10 −4 test/specs/commonTests/implementsShorthandProp.js
  36. +2 −1 test/specs/elements/Button/Button-test.js
  37. +3 −2 test/specs/elements/Header/Header-test.js
  38. +2 −1 test/specs/elements/Image/Image-test.js
  39. +4 −1 test/specs/elements/Input/Input-test.js
  40. +3 −2 test/specs/elements/Label/Label-test.js
  41. +19 −2 test/specs/elements/List/List-test.js
  42. +23 −0 test/specs/elements/List/ListItem-test.js
  43. +1 −1 test/specs/elements/Step/Step-test.js
  44. +2 −0 test/specs/elements/Step/StepContent-test.js
  45. +0 −113 test/specs/lib/eventStack/EventPool-test.js
  46. +0 −124 test/specs/lib/eventStack/EventSet-test.js
  47. +0 −134 test/specs/lib/eventStack/EventStack-test.js
  48. +0 −82 test/specs/lib/eventStack/EventTarget-test.js
  49. +0 −16 test/specs/lib/eventStack/normalizeHandlers-test.js
  50. +0 −41 test/specs/lib/eventStack/normalizeTarget-test.js
  51. +19 −13 test/specs/modules/Accordion/AccordionPanel-test.js
  52. +1 −0 test/specs/modules/Checkbox/Checkbox-test.js
  53. +29 −0 test/specs/modules/Dropdown/Dropdown-test.js
  54. +2 −1 test/specs/modules/Dropdown/DropdownHeader-test.js
  55. +11 −9 test/specs/modules/Dropdown/DropdownItem-test.js
  56. +5 −1 test/specs/modules/Embed/Embed-test.js
  57. +13 −2 test/specs/modules/Modal/Modal-test.js
  58. +38 −6 test/specs/modules/Popup/Popup-test.js
  59. +6 −1 test/specs/modules/Sticky/Sticky-test.js
  60. +3 −0 test/specs/views/Card/CardContent-test.js
  61. +5 −0 test/specs/views/Feed/FeedContent-test.js
  62. +2 −0 test/specs/views/Feed/FeedEvent-test.js
  63. +1 −1 test/specs/views/Feed/FeedLabel-test.js
  64. +1 −1 test/specs/views/Feed/FeedLike-test.js
  65. +1 −0 test/specs/views/Feed/FeedMeta-test.js
  66. +2 −0 test/specs/views/Feed/FeedSummary-test.js
  67. +1 −0 test/specs/views/Item/Item-test.js
  68. +5 −0 test/specs/views/Item/ItemContent-test.js
  69. +2 −0 test/specs/views/Stastistic/Statistic-test.js
  70. +0 −1 webpack.config.babel.js
  71. +827 −1,494 yarn.lock
10 changes: 5 additions & 5 deletions .github/stale.yml
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
# Number of days of inactivity before an issue becomes stale
daysUntilStale: 90
daysUntilStale: 180

# Number of days of inactivity before a stale issue is closed
daysUntilClose: 90
daysUntilClose: 180

# Issues with these labels will never be considered stale
exemptLabels:
@@ -14,7 +14,7 @@ staleLabel: stale

# Comment to post when marking an issue as stale. Set to `false` to disable
markComment: >
There has been no activity in this thread for 90 days. While we care about
There has been no activity in this thread for 180 days. While we care about
every issue and we’d love to see this fixed, the core team’s time is
limited so we have to focus our attention on the issues that are most
pressing. Therefore, we will likely not be able to get to this one.
@@ -23,11 +23,11 @@ markComment: >
However, PRs for this issue will of course be accepted and welcome!
If there is no more activity in the next 90 days, this issue will be closed
If there is no more activity in the next 180 days, this issue will be closed
automatically for housekeeping. To prevent this, simply leave a reply here.
Thanks!
# Comment to post when closing a stale issue. Set to `false` to disable
closeComment: >
This issue will be closed due to lack of activity for 6 months. If you’d
This issue will be closed due to lack of activity for 12 months. If you’d
like this to be reopened, just leave a comment; we do monitor them!
29 changes: 16 additions & 13 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@
# Change Log

## [v0.82.3](https://github.com/Semantic-Org/Semantic-UI-React/tree/v0.82.3) (2018-08-22)
[Full Changelog](https://github.com/Semantic-Org/Semantic-UI-React/compare/v0.82.2...v0.82.3)

**Merged pull requests:**

- fix\(Icon\): update icon names [\#3092](https://github.com/Semantic-Org/Semantic-UI-React/pull/3092) ([levithomason](https://github.com/levithomason))
- chore\(package\): update Babel to RC1 [\#3086](https://github.com/Semantic-Org/Semantic-UI-React/pull/3086) ([layershifter](https://github.com/layershifter))
- chore\(build\): fixes for UMD build [\#3085](https://github.com/Semantic-Org/Semantic-UI-React/pull/3085) ([layershifter](https://github.com/layershifter))
- chore\(package\): bump react-sandbox-render [\#3084](https://github.com/Semantic-Org/Semantic-UI-React/pull/3084) ([layershifter](https://github.com/layershifter))
- fix\(Message\): export size prop in typings [\#3083](https://github.com/Semantic-Org/Semantic-UI-React/pull/3083) ([layershifter](https://github.com/layershifter))
- docs\(Item\): cleanup examples [\#3082](https://github.com/Semantic-Org/Semantic-UI-React/pull/3082) ([ChenjieZhou](https://github.com/ChenjieZhou))
- chore\(config\): remove unused options [\#3080](https://github.com/Semantic-Org/Semantic-UI-React/pull/3080) ([layershifter](https://github.com/layershifter))
- docs\(build\): fix reloading of examples sources [\#3075](https://github.com/Semantic-Org/Semantic-UI-React/pull/3075) ([layershifter](https://github.com/layershifter))
- docs\(ComponentExample\): fix display of children [\#3070](https://github.com/Semantic-Org/Semantic-UI-React/pull/3070) ([layershifter](https://github.com/layershifter))

## [v0.82.2](https://github.com/Semantic-Org/Semantic-UI-React/tree/v0.82.2) (2018-08-07)
[Full Changelog](https://github.com/Semantic-Org/Semantic-UI-React/compare/v0.82.1...v0.82.2)

@@ -281,7 +296,7 @@

- docs\(Step\): fix display of an icon in StepExampleEvenlyDivided [\#2365](https://github.com/Semantic-Org/Semantic-UI-React/pull/2365) ([jeroenvervaeke](https://github.com/jeroenvervaeke))
- feat\(Button\): add `buttons` shorthand to ButtonGroup [\#2361](https://github.com/Semantic-Org/Semantic-UI-React/pull/2361) ([layershifter](https://github.com/layershifter))
- docs\(README.md\): add bailfacile.fr to list of websites using Semantic UI React [\#2357](https://github.com/Semantic-Org/Semantic-UI-React/pull/2357) ([potioventures](https://github.com/potioventures))
- docs\(README.md\): add bailfacile.fr to list of websites using Semantic UI React [\#2357](https://github.com/Semantic-Org/Semantic-UI-React/pull/2357) ([valentinfily](https://github.com/valentinfily))
- docs\(README.md\): add re.yomeshgupta.com to the build with list [\#2351](https://github.com/Semantic-Org/Semantic-UI-React/pull/2351) ([yomeshgupta](https://github.com/yomeshgupta))
- fix\(Transition\): fix of the choice of duration [\#2350](https://github.com/Semantic-Org/Semantic-UI-React/pull/2350) ([layershifter](https://github.com/layershifter))
- chore\(docgen|menugen\): fix problems with paths on Windows [\#2349](https://github.com/Semantic-Org/Semantic-UI-React/pull/2349) ([layershifter](https://github.com/layershifter))
@@ -345,18 +360,6 @@
- feat\(Responsive\): add `fireOnMount` prop [\#2137](https://github.com/Semantic-Org/Semantic-UI-React/pull/2137) ([layershifter](https://github.com/layershifter))
- docs\(ComponentDoc\): refactor and optimize [\#2123](https://github.com/Semantic-Org/Semantic-UI-React/pull/2123) ([layershifter](https://github.com/layershifter))

## [v0.75.1](https://github.com/Semantic-Org/Semantic-UI-React/tree/v0.75.1) (2017-10-18)
[Full Changelog](https://github.com/Semantic-Org/Semantic-UI-React/compare/v0.75.0...v0.75.1)

**Merged pull requests:**

- fix\(FormField\): pass content prop through [\#2212](https://github.com/Semantic-Org/Semantic-UI-React/pull/2212) ([levithomason](https://github.com/levithomason))
- fix\(Responsive\): fix usage of `window` for SSR [\#2209](https://github.com/Semantic-Org/Semantic-UI-React/pull/2209) ([layershifter](https://github.com/layershifter))
- docs\(Form\): fix typo in label [\#2208](https://github.com/Semantic-Org/Semantic-UI-React/pull/2208) ([layershifter](https://github.com/layershifter))
- feat\(typings\): export DropdownOnSearchChangeData [\#2205](https://github.com/Semantic-Org/Semantic-UI-React/pull/2205) ([pierre-H](https://github.com/pierre-H))
- chore\(circleci\): fix typo in a step name [\#2200](https://github.com/Semantic-Org/Semantic-UI-React/pull/2200) ([WiNloSt](https://github.com/WiNloSt))
- fix\(TextArea\): fix autoHeight calculate wrong value on long text [\#2199](https://github.com/Semantic-Org/Semantic-UI-React/pull/2199) ([WiNloSt](https://github.com/WiNloSt))



\* *This Change Log was automatically generated by [github_changelog_generator](https://github.com/skywinder/Github-Changelog-Generator)*
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -16,7 +16,7 @@
<img alt="Gitter" src="https://img.shields.io/badge/gitter-join_chat-1dce73.svg?logo=data%3Aimage%2Fsvg%2Bxml%3Bbase64%2CPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNvZGluZz0iVVRGLTgiPz4NCjxzdmcgeG1sbnM9Imh0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnIj48cmVjdCB4PSIwIiB5PSI1IiBmaWxsPSIjZmZmIiB3aWR0aD0iMSIgaGVpZ2h0PSI1Ii8%2BPHJlY3QgeD0iMiIgeT0iNiIgZmlsbD0iI2ZmZiIgd2lkdGg9IjEiIGhlaWdodD0iNyIvPjxyZWN0IHg9IjQiIHk9IjYiIGZpbGw9IiNmZmYiIHdpZHRoPSIxIiBoZWlnaHQ9IjciLz48cmVjdCB4PSI2IiB5PSI2IiBmaWxsPSIjZmZmIiB3aWR0aD0iMSIgaGVpZ2h0PSI0Ii8%2BPC9zdmc%2B&logoWidth=8&style=flat-square&maxAge=2592000" />
</a>
<a href="https://circleci.com/gh/Semantic-Org/Semantic-UI-React/tree/master">
<img alt="Circle" src="https://img.shields.io/circleci/project/Semantic-Org/Semantic-UI-React/master.svg?style=flat-square" />
<img alt="Circle" src="https://img.shields.io/circleci/project/github/Semantic-Org/Semantic-UI-React/master.svg?style=flat-square" />
</a>
<a href="https://codecov.io/gh/Semantic-Org/Semantic-UI-React">
<img alt="Codecov" src="https://img.shields.io/codecov/c/github/Semantic-Org/Semantic-UI-React/master.svg?style=flat-square" />
1 change: 0 additions & 1 deletion config.js
Original file line number Diff line number Diff line change
@@ -86,7 +86,6 @@ const config = {
'classnames',
'copy-to-clipboard',
'faker',
'prettier/standalone',
'react',
'react-ace',
'react-dom',
Original file line number Diff line number Diff line change
@@ -71,14 +71,18 @@ class ComponentExample extends PureComponent {
}

componentWillReceiveProps(nextProps) {
const { examplePath, exampleSources, location } = nextProps
const nextSourceCode = exampleSources[examplePath]

// deactivate examples when switching from one to the next
if (
this.isActiveHash() &&
this.isActiveState() &&
this.props.location.hash !== nextProps.location.hash
) {
if (this.isActiveHash() && this.isActiveState() && this.props.location.hash !== location.hash) {
this.clearActiveState()
}

// for local environment
if (process.env.NODE_ENV !== 'production' && this.getOriginalSourceCode() !== nextSourceCode) {
this.setState({ sourceCode: nextSourceCode })
}
}

clearActiveState = () => {
Original file line number Diff line number Diff line change
@@ -5,7 +5,7 @@ import { Button, Popup, Segment, Menu } from 'semantic-ui-react'

import Editor, { EDITOR_BACKGROUND_COLOR } from 'docs/src/components/Editor/Editor'
import { updateForKeys } from 'docs/src/hoc'
import { formatCode } from 'docs/src/utils'
import formatCode from 'docs/src/utils/formatCode'

const rootStyle = {
position: 'relative',
Original file line number Diff line number Diff line change
@@ -3,7 +3,7 @@ import React, { PureComponent } from 'react'
import { Divider } from 'semantic-ui-react'

import Editor, { EDITOR_BACKGROUND_COLOR } from 'docs/src/components/Editor/Editor'
import { formatCode } from 'docs/src/utils'
import formatCode from 'docs/src/utils/formatCode'

const rootStyle = {
padding: '1rem',
4 changes: 4 additions & 0 deletions docs/src/utils/formatCode.js
Original file line number Diff line number Diff line change
@@ -4,6 +4,10 @@ import prettierConfig from '../../../.prettierrc.json'
delete prettierConfig.$schema
delete prettierConfig.overrides

// Heads up!
// Please use this function directly and don't reexport it in utils.
// https://github.com/prettier/prettier/issues/4959

const formatCode = (code) => {
if (!code) return ''

1 change: 0 additions & 1 deletion docs/src/utils/index.js
Original file line number Diff line number Diff line change
@@ -4,7 +4,6 @@ export btoa from './btoa'
export * from './constants'
export componentInfoContext from './componentInfoContext'
export examplePathToHash from './examplePathToHash'
export formatCode from './formatCode'
export getComponentPathname from './getComponentPathname'
export getFormattedHash from './getFormattedHash'
export parseExamplePath from './parseExamplePath'
17 changes: 6 additions & 11 deletions gulp/plugins/gulp-example-source.js
Original file line number Diff line number Diff line change
@@ -1,14 +1,16 @@
import Vinyl from 'vinyl'
import gutil from 'gulp-util'
import _ from 'lodash'
import path from 'path'
import through from 'through2'
import Vinyl from 'vinyl'

// Heads up!
// This plugin is not universal, so it's okay to keep all existing sources as the state.
// https://github.com/Semantic-Org/Semantic-UI-React/issues/3095
const exampleSources = {}
const pluginName = 'gulp-example-source'

export default () => {
const exampleSources = {}

function bufferContents(file, enc, cb) {
if (file.isNull()) {
cb(null, file)
@@ -41,16 +43,9 @@ export default () => {
function endStream(cb) {
const file = new Vinyl({
path: './exampleSources.json',
contents: Buffer.from(JSON.stringify(exampleSources, null, 2)),
})
let existingSources = {}

// Heads up!
// In watch mode we should update only single entry that matches changed file.
if (file.contents) {
existingSources = JSON.parse(file.contents.toString())
}

file.contents = Buffer.from(JSON.stringify({ ...existingSources, ...exampleSources }, null, 2))
this.push(file)
cb()
}
37 changes: 27 additions & 10 deletions gulp/tasks/docs.js
Original file line number Diff line number Diff line change
@@ -18,6 +18,24 @@ const { log } = g.util
const handleWatchChange = filename =>
log(`File ${path.basename(filename)} was changed, running tasks...`)

/**
* Converts paths with globs to supported by chokidar, is more specific for Windows where
* is different path sep.
* Example of the failure behaviour: "C:\projects\docs/examples/index.js"
*
* @param {String} directory
* @param {String} glob
* @returns {String}
*/
const toUniversalGlob = (directory, glob) => {
const relative = path
.relative(process.cwd(), directory)
.split(path.sep)
.join('/')

return `${relative}/${glob}`
}

// ----------------------------------------
// Clean
// ----------------------------------------
@@ -76,17 +94,17 @@ task('build:docs:static:start', (cb) => {
// ----------------------------------------

const componentsSrc = [
`${paths.src()}/addons/*/*.js`,
`${paths.src()}/behaviors/*/*.js`,
`${paths.src()}/elements/*/*.js`,
`${paths.src()}/collections/*/*.js`,
`${paths.src()}/modules/*/*.js`,
`${paths.src()}/views/*/*.js`,
toUniversalGlob(paths.src(), 'addons/*/*.js'),
toUniversalGlob(paths.src(), 'behaviors/*/*.js'),
toUniversalGlob(paths.src(), 'elements/*/*.js'),
toUniversalGlob(paths.src(), 'collections/*/*.js'),
toUniversalGlob(paths.src(), 'modules/*/*.js'),
toUniversalGlob(paths.src(), 'views/*/*.js'),
'!**/index.js',
]

const examplesSectionsSrc = `${paths.docsSrc()}/examples/*/*/*/index.js`
const examplesSrc = `${paths.docsSrc()}/examples/*/*/*/!(*index).js`
const examplesSectionsSrc = toUniversalGlob(paths.docsSrc(), 'examples/*/*/*/index.js')
const examplesSrc = toUniversalGlob(paths.docsSrc(), 'examples/*/*/*/!(*index).js')

task('build:docs:cname', (cb) => {
sh(`echo react.semantic-ui.com > ${paths.docsDist('CNAME')}`, cb)
@@ -151,7 +169,7 @@ task('deploy:docs', (cb) => {
// Watch
// ----------------------------------------

task('watch:docs', (cb) => {
task('watch:docs', () => {
// rebuild component info
watch(componentsSrc, series('build:docs:docgen', 'build:docs:static:reload')).on(
'change',
@@ -169,7 +187,6 @@ task('watch:docs', (cb) => {
'change',
handleWatchChange,
)
cb()
})

// ----------------------------------------
Loading