Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: Semantic-Org/Semantic-UI-React
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.81.2
Choose a base ref
...
head repository: Semantic-Org/Semantic-UI-React
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.81.3
Choose a head ref
  • 4 commits
  • 8 files changed
  • 3 contributors

Commits on Jun 27, 2018

  1. feat(Flag): export names in typings (#2957) 

    * feat(Flag): export names in typings
    @layershifter
    layershifter authored Jun 27, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    f23d42d View commit details

  2. fix(Dropdown): fix double onClose() after blur (#2959) 

     fix(Dropdown): fix double onClose() after blur
    @layershifter
    layershifter authored Jun 27, 2018

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    e2e9c1e View commit details

  3. fix(Portal): remove non-working style prop (#2958) 

    * Update Portal.js to fix IE bug

Instead of setting the style property of a dom node (which is a read-only attribute), we set the cssText property instead.

See https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/style for additional documentation.

Even so, most browsers allow setting style directly.  However, doing this in IE causes a crash.

* Removing style prop from Portal.js per feedback.

* Update Portal.d.ts

* Update Portal.js
    @mgandley @levithomason
    mgandley authored and levithomason committed Jun 27, 2018
    Copy the full SHA
    ea0f5ae View commit details

  4. 0.81.3

    @levithomason
    levithomason committed Jun 27, 2018
    Copy the full SHA
    487eacf View commit details
Showing with 529 additions and 517 deletions.
  1. +2 −1 index.d.ts
  2. +1 −1 package.json
  3. +0 −3 src/addons/Portal/Portal.d.ts
  4. +1 −5 src/addons/Portal/Portal.js
  5. +494 −492 src/elements/Flag/Flag.d.ts
  6. +1 −1 src/elements/Flag/index.d.ts
  7. +18 −13 src/modules/Dropdown/Dropdown.js
  8. +12 −1 test/specs/modules/Dropdown/Dropdown-test.js
3 changes: 2 additions & 1 deletion index.d.ts
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
// Addons

export { default as Confirm, ConfirmProps } from './dist/commonjs/addons/Confirm'
export { default as MountNode, MountNodeProps } from './dist/commonjs/addons/MountNode'
export { default as Pagination, PaginationProps } from './dist/commonjs/addons/Pagination'
@@ -134,7 +135,7 @@ export { default as Container, ContainerProps } from './dist/commonjs/elements/C

export { default as Divider, DividerProps } from './dist/commonjs/elements/Divider'

export { default as Flag, FlagProps } from './dist/commonjs/elements/Flag'
export { default as Flag, FlagNameValues, FlagProps } from './dist/commonjs/elements/Flag'

export { default as Header, HeaderProps } from './dist/commonjs/elements/Header'
export {
2 changes: 1 addition & 1 deletion package.json
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "semantic-ui-react",
"version": "0.81.2",
"version": "0.81.3",
"description": "The official Semantic-UI-React integration.",
"jsnext:main": "dist/es/index.js",
"main": "dist/commonjs/index.js",
3 changes: 0 additions & 3 deletions src/addons/Portal/Portal.d.ts
View file
Original file line number Diff line number Diff line change
@@ -101,9 +101,6 @@ export interface PortalProps {
/** Controls whether the portal should be prepended to the mountNode instead of appended. */
prepend?: boolean

/** Any inline styles to the Portal container. */
style?: object

/** Element to be rendered in-place where the portal is defined. */
trigger?: React.ReactNode
}
6 changes: 1 addition & 5 deletions src/addons/Portal/Portal.js
View file
Original file line number Diff line number Diff line change
@@ -122,9 +122,6 @@ class Portal extends Component {
/** Controls whether the portal should be prepended to the mountNode instead of appended. */
prepend: PropTypes.bool,

/** Any inline styles to the Portal container. */
style: PropTypes.object,

/** Element to be rendered in-place where the portal is defined. */
trigger: PropTypes.node,
}
@@ -344,15 +341,14 @@ class Portal extends Component {
if (!this.state.open) return
debug('renderPortal()')

const { children, className, eventPool, style } = this.props
const { children, className, eventPool } = this.props

this.mountPortal()

// Server side rendering
if (!isBrowser()) return null

this.rootNode.className = className || ''
this.rootNode.style = style || ''

// when re-rendering, first remove listeners before re-adding them to the new node
if (this.portalNode) {
Loading