[rb] Resolve uri gem deprecation warning

[Earlopain]

User description

Description

Ruby switches the default parser from RFC2396 to RFC3986. This parser contains all methods from the old parser but delegates to RFC2396 for a few and warns. Namely extract, make_regexp, escape, and unescape.

selenium currently supports Ruby >= 3.1, so the current old compatibility code is unnecessary. RFC2396_PARSER is a somewhat new addition, so some kind of check is still needed. It is available in Ruby 3.1 but early patch versions are missing it.

Motivation and Context

/home/user/.rbenv/versions/3.3.6/lib/ruby/gems/3.3.0/gems/selenium-webdriver-4.26.0/lib/selenium/webdriver/remote/bridge.rb:679: warning: URI::RFC3986_PARSER.escape is obsoleted. Use URI::RFC2396_PARSER.escape explicitly.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

---

PR Type

Bug fix

---

Description

• Updated the escaper method in bridge.rb to resolve a deprecation warning by using URI::RFC2396_PARSER when available.
• Ensured compatibility with Ruby versions >= 3.1 by checking for the presence of URI::RFC2396_PARSER.
• This change addresses the obsolescence of URI::RFC3986_PARSER.escape.

---

Changes walkthrough 📝

	Relevant files
Bug fix	bridge.rb Resolve deprecation warning by updating URI parser usage  rb/lib/selenium/webdriver/remote/bridge.rb Updated the escaper method to use URI::RFC2396_PARSER if defined. Fallback to URI::DEFAULT_PARSER if URI::RFC2396_PARSER is not defined. +1/-1

---

💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

[qodo-merge-pro]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Backward Compatibility Verify that the fallback to URI::DEFAULT_PARSER works correctly on older Ruby versions where URI::RFC2396_PARSER is not defined

[qodo-merge-pro]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Add defensive programming to handle cases where neither URI parser is available Add a nil check for the escaper instance to handle potential undefined parser cases, preventing runtime errors. rb/lib/selenium/webdriver/remote/bridge.rb [689] -@escaper ||= defined?(URI::RFC2396_PARSER) ? URI::RFC2396_PARSER : URI::DEFAULT_PARSER +@escaper ||= if defined?(URI::RFC2396_PARSER) + URI::RFC2396_PARSER +elsif defined?(URI::DEFAULT_PARSER) + URI::DEFAULT_PARSER +else + raise RuntimeError, 'No URI parser available' +end Apply this suggestion Suggestion importance[1-10]: 8 Why: The suggestion adds important error handling to prevent silent failures if both URI parsers are undefined, which could lead to runtime errors. This defensive programming approach improves the code's robustness and provides clearer error messages.	8

💡 Need additional feedback ? start a PR chat

[aguspe]

Documentation reference for this change: https://bugs.ruby-lang.org/issues/19266

[aguspe]

Thank you @Earlopain for your contribution! Have a great day!

[Earlopain]

Thanks (: You have a good one as well