Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🚀 Feature]: Selenium Manager support Nightly grid #13384

Closed
titusfortner opened this issue Jan 2, 2024 · 6 comments
Closed

[🚀 Feature]: Selenium Manager support Nightly grid #13384

titusfortner opened this issue Jan 2, 2024 · 6 comments

Comments

@titusfortner
Copy link
Member

titusfortner commented Jan 2, 2024

Feature and motivation

Allow automatically downloading the nightly version of the grid.

Instead of just getting the latest version of grid, SM should allow getting a specific version. The primary use case for this is to be able to use the nightly release version, but the logic should be the same as what we're doing for IE Driver I think.

Usage example

Result result = SeleniumManager.getResult(List.of("--grid", "nightly"));
Runtime.getRuntime().exec("java -jar " + result.getGridPath() + " standalone --port 12345");

I know the jar can be executed itself in Java, so this more of an example of what would be done in the other languages.

@bonigarcia
Copy link
Member

This is already possible. As the doc says:

Optionally, the argument --grid allows to specify a Selenium Grid version (--grid <GRID_VERSION>).

For instance:

./selenium-manager --debug --grid 4.17.0-SNAPSHOT
DEBUG   grid not found in the system
DEBUG   Downloading selenium-server 4.17.0-SNAPSHOT from https://github.com/SeleniumHQ/selenium/releases/download/nightly/selenium-server-4.17.0-SNAPSHOT.jar
INFO    Driver path: C:\Users\boni\.cache\selenium\grid\4.17.0-SNAPSHOT\selenium-server-4.17.0-SNAPSHOT.jar

@bonigarcia
Copy link
Member

Unless you want to match the label nightly with the current nightly version. In that case, yes, that is something new that can be implemented.

@titusfortner
Copy link
Member Author

Hah. I thought it was possible, but didn't see grid-version like I was expecting. Just --grid makes sense.

Let me update this to say support nightly. Thanks.

@titusfortner titusfortner changed the title [🚀 Feature]: Selenium Manager support grid version [🚀 Feature]: Selenium Manager support Nightly grid Jan 19, 2024
@diemol
Copy link
Member

diemol commented May 16, 2024

During the May 2024 Selenium Summit, we decided to implement this. Supporting stable (latest release) and nightly.

@diemol diemol moved this to Low in Selenium Manager May 16, 2024
Copy link

This issue is stale because it has been open 280 days with no activity. Remove stale label or comment or this will be closed in 14 days.

@github-actions github-actions bot added the I-stale Applied to issues that become stale, and eventually closed. label Jan 14, 2025
@bonigarcia bonigarcia removed the I-stale Applied to issues that become stale, and eventually closed. label Jan 14, 2025
@bonigarcia bonigarcia moved this from Low to In Progress in Selenium Manager Mar 3, 2025
bonigarcia added a commit that referenced this issue Mar 3, 2025
bonigarcia added a commit that referenced this issue Mar 3, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
bonigarcia added a commit that referenced this issue Mar 3, 2025
bonigarcia added a commit that referenced this issue Mar 3, 2025
bonigarcia added a commit that referenced this issue Mar 10, 2025
@bonigarcia
Copy link
Member

Closed via #15366.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Selenium Manager Mar 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

3 participants