-
-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'browserName' capability from stereotype when using RelaySession #14247
Conversation
…resent is SessionRequest
PR Reviewer Guide 🔍
|
PR Code Suggestions ✨
|
java/src/org/openqa/selenium/grid/node/relay/RelaySessionFactory.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @bhecquet!
…on (SeleniumHQ#14247) * Remove 'browserName' capability from stereotype. We expect it to be present is SessionRequest * Only remove 'browserName' when 'appium:app' is present * Formatting file --------- Co-authored-by: Diego Molina <diemol@users.noreply.github.com> Co-authored-by: Diego Molina <diemol@gmail.com>
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
Remove browserName capability from stereotype before merging requested capabilities and stereotype.
Motivation and Context
When using Selenium Grid relay with appium and trying to test a mobile application, if node declares a browserName in stereotype, this browserName is added to capabilities sent to appium
Solves issue #14216
Moreover, if the session would need a browser, browserName capability would be provided in session request
Types of changes
Checklist
I've tested the change in the situation where the problem occured, and it's solved.
PR Type
Bug fix
Description
browserName
capability from the stereotype inRelaySessionFactory
to prevent conflicts with Appium tests when an app is provided.MutableCapabilities
andCapabilityType
to facilitate these changes.Changes walkthrough 📝
RelaySessionFactory.java
Remove
browserName
capability from stereotype in RelaySessionFactoryjava/src/org/openqa/selenium/grid/node/relay/RelaySessionFactory.java
MutableCapabilities
andCapabilityType
.browserName
capability from the stereotype to avoid conflictswith Appium tests.