Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sensor metadata lost with pandas==2.1 #148

Closed
Flix6x opened this issue Oct 13, 2023 · 2 comments · Fixed by #158
Closed

Sensor metadata lost with pandas==2.1 #148

Flix6x opened this issue Oct 13, 2023 · 2 comments · Fixed by #158

Comments

@Flix6x
Copy link
Collaborator

Flix6x commented Oct 13, 2023

Tests failing with Pandas==2.1 (Python>=3.9), see https://github.com/SeitaBV/timely-beliefs/actions/runs/6509432942/job/17680939655?pr=147.

AttributeError: 'BeliefsDataFrame' object has no attribute 'sensor'
@Flix6x
Copy link
Collaborator Author

Flix6x commented Oct 13, 2023

Among other tests, our test_groupby_preserves_metadata is failing. Looks like groupby is losing metadata again, and this is a method we use a lot. I went through the Pandas 2.1.0 changelog but could not yet find an obvious cause. There has been work done on both metadata and on groupby.

@Flix6x
Copy link
Collaborator Author

Flix6x commented Dec 7, 2023

Pandas==2.1.2 fixed this regression. Probably this one.

@Flix6x Flix6x linked a pull request Dec 8, 2023 that will close this issue
dependencies: exclude Pandas versions that lose metadata #158
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dependencies: exclude Pandas versions that lose metadata SeitaBV/timely-beliefs
1 participant
@Flix6x