package(mongo) [STORY-1030] Add option to define a customer method in order to pass custom query method (to look at paranoid-deleted items for instance

[leo-scalingo]

• Add a changelog entry in CHANGELOG.md

[notion-workspace]

Prototype: integration with database-core: listing databases

[sc-zenokerr]

This looks good, but I think it misses a bit of documentation and some tests.
I think it is important to define the intended behaviour with regards to pagination and sort order and test for that behaviour. It "may" avoid confusion in the future.
What do you think?

[leo-scalingo]

What kind of tests would you add? In a way that the rest of the behavior is not changed, only the query getting the documents, that's why I only tested this. If you have one or two test cases to add I would definitely add them

Thanks for your review and I'll add the missing documentation

[sc-zenokerr]

There are already a test cases for returning the second page:

• "It should return the second page"
• "It should return the second page in reverse order"

I would suggest adding equivalent tests when using the custom QueryFunc.

I think this would make it clear how we expect the library to behave with regards to pagination and sort order when using QueryFunc

What do you think?

[leo-scalingo]

What do you think?

https://github.com/Scalingo/go-utils/pull/997/files#diff-e90d6bda755cb9479c9f732f823ac4aa98ebff14bc0bb7c1607d0d9bb5418cd6R115-R120

To me the change is minor enough to not having to redo the whole test matrix.

• Arguments are used the same way
• The library is not responsible of the WhereQuery anymore, if I would test more testcases, I would not test this change but document.WhereUnscopedQuery, a user of the library could build a custom QueryFunc which breaks the sorting because it takes the argument but does nothing with it, and then it wouldn't be the responsibility of the library. So I'm not sure it's pertinent to test all options.

[sc-zenokerr]

LGTM. Nice