Skip to content

Suggest similar columns if column gets accessed that doesn't exist #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
lars-reimann opened this issue Apr 18, 2023 · 3 comments · Fixed by #385
Closed

Suggest similar columns if column gets accessed that doesn't exist #203

lars-reimann opened this issue Apr 18, 2023 · 3 comments · Fixed by #385
Assignees
@robmeth @jxnior01
Labels
released Included in a release

Comments

@lars-reimann
Copy link
Member

lars-reimann commented Apr 18, 2023 •
edited
Loading

Is your feature request related to a problem?

Sometimes people just mistype a column name.

Desired solution

  • We should see whether a column with a similar name exists in the current Table and include this in the error message ("did you mean XY"). To compute similarity of column names, use levenshtein.

Possible alternatives (optional)

No response

Screenshots (optional)

No response

Additional Context (optional)

If a column with the given name has existed in the past (#328), we should show that instead of looking for columns with similar names.
@github-project-automation github-project-automation bot moved this to Backlog in Library Apr 18, 2023
@lars-reimann lars-reimann changed the title Improve error messages when no column with given name exists Suggest similar columns if column gets accessed that doesn't exist May 26, 2023
@guenterk
Copy link

guenterk commented Jun 9, 2023

If a column with the given name has existed in the past (#328), we should show that FIRST ("Column XYZ has been removed using METHOD.") AND still suggest columns with similar names, AFTERWARDS ("Or did you mean column XXZ?").

@PhilipGutberlet PhilipGutberlet moved this from Backlog to Todo in Library Jun 16, 2023
@robmeth robmeth moved this from Todo to In Progress in Library Jun 23, 2023
@robmeth robmeth linked a pull request Jun 23, 2023 that will close this issue
feat: suggest similar columns if column gets accessed that doesnt exist #385
Merged
@robmeth robmeth mentioned this issue Jun 23, 2023
Merged
@robmeth robmeth moved this from In Progress to 🧱 Blocked in Library Jun 23, 2023
@robmeth
Copy link
Contributor

robmeth commented Jun 23, 2023 •
edited
Loading

blocked because we need #328 to include the columns that have been removed

@lars-reimann lars-reimann moved this from 🧱 Blocked to Backlog in Library Jun 30, 2023
@daniaHu daniaHu moved this from Backlog to Todo in Library Jun 30, 2023
@jxnior01 jxnior01 moved this from Todo to In Progress in Library Jun 30, 2023
@jxnior01 jxnior01 moved this from In Progress to Ready for Review in Library Jul 13, 2023
@zzril zzril moved this from Ready for Review to In Progress in Library Jul 13, 2023
@jxnior01 jxnior01 moved this from In Progress to Ready for Review in Library Jul 13, 2023
@lars-reimann lars-reimann moved this from Ready for Review to Ready to Merge in Library Jul 13, 2023
jxnior01 added a commit that referenced this issue Jul 13, 2023
@robmeth @jxnior01
feat: suggest similar columns if column gets accessed that doesnt exi…

Verified

This commit was signed with the committer’s verified signature.
sebastianbergmann Sebastian Bergmann
GPG key ID: 4AA394086372C20A
Verified
Learn about vigilant mode
6a097a4 
…st (#385)

Closes #203

### Summary of Changes

* Added a method `_get_similar_columns` to find columns with a name
similar to a given name.
* Updated `UnknownColumnNameError` to allow for passing name
suggestions.
* Used these suggestions in `get_column`, `keep_only_columns`,
`remove_columns`, `rename_column`, `replace_column`, `transform_column`,
`plot_lineplot`, `plot_scatterplot`.

Co-authored-by: jxnior01 <129027012+jxnior01@users.noreply.github.com>
@github-project-automation github-project-automation bot moved this from Ready to Merge to ✔️ Done in Library Jul 13, 2023
lars-reimann pushed a commit that referenced this issue Jul 13, 2023
@semantic-release-bot
chore(release): 0.15.0 [skip ci]

Verified

This commit was signed with the committer’s verified signature.
sebastianbergmann Sebastian Bergmann
GPG key ID: 4AA394086372C20A
Verified
Learn about vigilant mode
a52bc18 
## [0.15.0](v0.14.0...v0.15.0) (2023-07-13)

### Features

* Add copy method for tables ([#405](#405)) ([72e87f0](72e87f0)), closes [#275](#275)
* add gaussian noise to image ([#430](#430)) ([925a505](925a505)), closes [#381](#381)
* add schema conversions when adding new rows to a table and schema conversion when creating a new table ([#432](#432)) ([6e9ff69](6e9ff69)), closes [#404](#404) [#322](#322) [#127](#127) [#322](#322) [#127](#127)
* add test for empty tables for the method `Table.sort_rows` ([#431](#431)) ([f94b768](f94b768)), closes [#402](#402)
* added color adjustment feature ([#409](#409)) ([2cbee36](2cbee36)), closes [#380](#380)
* added test_repr table tests ([#410](#410)) ([cb77790](cb77790)), closes [#349](#349)
* discretize table ([#327](#327)) ([5e3da8d](5e3da8d)), closes [#143](#143)
* Improve error handling of TaggedTable ([#450](#450)) ([c5da544](c5da544)), closes [#150](#150)
* Maintain tagging in methods inherited from `Table` class ([#332](#332)) ([bc73a6c](bc73a6c)), closes [#58](#58)
* new error class `OutOfBoundsError` ([#438](#438)) ([1f37e4a](1f37e4a)), closes [#262](#262)
* rename several `Table` methods for consistency ([#445](#445)) ([9954986](9954986)), closes [#439](#439)
* suggest similar columns if column gets accessed that doesnt exist ([#385](#385)) ([6a097a4](6a097a4)), closes [#203](#203)

### Bug Fixes

* added the missing ids in parameterized tests ([#412](#412)) ([dab6419](dab6419)), closes [#362](#362)
* don't warn if `Imputer` transforms column without missing values ([#448](#448)) ([f0cb6a5](f0cb6a5))
* Warnings raised by underlying seaborn and numpy libraries  ([#425](#425)) ([c4143af](c4143af)), closes [#357](#357)
@lars-reimann
Copy link
Member Author

🎉 This issue has been resolved in version 0.15.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robmeth robmeth

@jxnior01 jxnior01

Labels
released Included in a release
Projects
Library
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: suggest similar columns if column gets accessed that doesnt exist Safe-DS/Library
4 participants
@lars-reimann @guenterk @robmeth @jxnior01