-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork figures package so it can be published for esm/cjs #1388
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1388 +/- ##
==========================================
+ Coverage 94.46% 96.83% +2.36%
==========================================
Files 53 54 +1
Lines 4556 4927 +371
Branches 772 808 +36
==========================================
+ Hits 4304 4771 +467
+ Misses 247 148 -99
- Partials 5 8 +3 ☔ View full report in Codecov by Sentry. |
Thanks! I pushed an extra update to also cover |
Ok great! Wasn't sure about that one. Was about to write some tests to please codecov, they're pretty trivial though so let me know if it's worthwhile doing so. |
I'm fine ignoring the codecov. But if it's trivial, it does make it easier to manage when people send PRs. |
You can also ignore the linting job; it's because the package is not published, and to make the linting job faster it doesn't depends on building the package. |
I went ahead and push a release right now since I'm planning to get breaking change in today. A follow-up PR with test would be great if you're still planning it. Last point is debugging the eslint failure; since I was wrong 🤦🏻 #1389 |
Closes #1386
This pr ports the
is-unicode-supported
andfigures
packages so they can be dual published in ESM/CJS.