Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fork figures package so it can be published for esm/cjs #1388

Merged
merged 4 commits into from
Apr 12, 2024

Conversation

jeffsee55
Copy link
Contributor

@jeffsee55 jeffsee55 commented Apr 12, 2024

Closes #1386

This pr ports the is-unicode-supported and figures packages so they can be dual published in ESM/CJS.

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 93.27217% with 22 lines in your changes are missing coverage. Please review.

Project coverage is 96.83%. Comparing base (0dfa6bd) to head (023295b).
Report is 38 commits behind head on master.

Files Patch % Lines
packages/figures/src/index.mts 93.14% 16 Missing and 6 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1388      +/-   ##
==========================================
+ Coverage   94.46%   96.83%   +2.36%     
==========================================
  Files          53       54       +1     
  Lines        4556     4927     +371     
  Branches      772      808      +36     
==========================================
+ Hits         4304     4771     +467     
+ Misses        247      148      -99     
- Partials        5        8       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias
Copy link
Owner

Thanks! I pushed an extra update to also cover inquirer.

@jeffsee55
Copy link
Contributor Author

Ok great! Wasn't sure about that one. Was about to write some tests to please codecov, they're pretty trivial though so let me know if it's worthwhile doing so.

@SBoudrias
Copy link
Owner

I'm fine ignoring the codecov. But if it's trivial, it does make it easier to manage when people send PRs.

@SBoudrias
Copy link
Owner

SBoudrias commented Apr 12, 2024

You can also ignore the linting job; it's because the package is not published, and to make the linting job faster it doesn't depends on building the package.

@SBoudrias SBoudrias changed the title Inline figures package so it can be published for esm/cjs Fork figures package so it can be published for esm/cjs Apr 12, 2024
@SBoudrias SBoudrias merged commit 7596270 into SBoudrias:master Apr 12, 2024
6 of 8 checks passed
@SBoudrias
Copy link
Owner

I went ahead and push a release right now since I'm planning to get breaking change in today.

A follow-up PR with test would be great if you're still planning it.

Last point is debugging the eslint failure; since I was wrong 🤦🏻 #1389

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support unicode for Windows
2 participants