Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update timeout example #1373

Merged
merged 4 commits into from Mar 21, 2024
Merged

Chore: Update timeout example #1373

merged 4 commits into from Mar 21, 2024

Conversation

mdonnalley
Copy link
Contributor

The Get Default Value After Timeout recipe didn't work for me since the process would wait until the timeout completed to exit.

I've updated the recipe to abort the timeout once the prompt has been answered.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.08%. Comparing base (0dfa6bd) to head (914564b).
Report is 25 commits behind head on master.

❗ Current head 914564b differs from pull request most recent head 4cea973. Consider uploading reports for the commit 4cea973 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1373      +/-   ##
==========================================
+ Coverage   94.46%   97.08%   +2.61%     
==========================================
  Files          53       53              
  Lines        4556     4600      +44     
  Branches      772      799      +27     
==========================================
+ Hits         4304     4466     +162     
+ Misses        247      132     -115     
+ Partials        5        2       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias
Copy link
Owner

Hi! Thanks a lot for sending this PR. This feedback is point on 😄

I went ahead and slightly edited the demo to use less open variables and follow the project coding style.

I also added it into a live demo on @inquirer/demo as it'll be easier to run and test. Cheers 🎉

@SBoudrias SBoudrias merged commit bf9b433 into SBoudrias:master Mar 21, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants