Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Automatic builds for macOS #4836

Closed
karwa opened this issue May 6, 2023 · 12 comments · Fixed by #4837
Closed

[Feature Request] Automatic builds for macOS #4836

karwa opened this issue May 6, 2023 · 12 comments · Fixed by #4837
Labels
enhancement New feature or request infra Related to the project infrastructure os:macOS An issue or feature request exclusively relating to macOS

Comments

@karwa
Copy link

karwa commented May 6, 2023

Overview

Currently, the bot which generates binaries appears to only do so for Windows and Linux (example):

image

It would be nice to provide builds for macOS users, too.

Smaller details

N/A

Nature of request

Infrastructure

Why would this feature be useful?

So macOS users can try the latest builds without needing to download the .Net SDK and build the project manually.

@TSRBerry
Copy link
Member

TSRBerry commented May 7, 2023

We could do this if Github Actions supported Arm64, but they don't.

See these issues for more context:

@gdkchan
Copy link
Member

gdkchan commented May 7, 2023

Is it not possible to cross-compile from x86 to arm64?

@TSRBerry
Copy link
Member

TSRBerry commented May 7, 2023

If we are able to use codesign on Linux or Windows it should be possible, although the build times will probably increase a lot and they are already huge.

@gdkchan
Copy link
Member

gdkchan commented May 7, 2023

We already have Github Action building for macOS on the other repo iirc, so it's totally possible. The only limitation is that we can't run the tests without a mac arm64 machine.

@TSRBerry
Copy link
Member

TSRBerry commented May 7, 2023

I thought this was running on an arm64 self-hosted runner from @marysaka, but it doesn't look like that's the case.
If you have no objections because of the missing tests, I could add the pieces for that to our CI here.

@TSRBerry TSRBerry self-assigned this May 7, 2023
@TSRBerry TSRBerry added enhancement New feature or request os:macOS An issue or feature request exclusively relating to macOS infra Related to the project infrastructure labels May 7, 2023
@marysaka
Copy link
Contributor

marysaka commented May 7, 2023

I thought this was running on an arm64 self-hosted runner from @marysaka, but it doesn't look like that's the case. If you have no objections because of the missing tests, I could add the pieces for that to our CI here.

We would need a runner somwhere for that still

@TSRBerry
Copy link
Member

TSRBerry commented May 7, 2023

I think we should probably wait for Github to add arm64 runners to run the tests for that as well.

@gdkchan
Copy link
Member

gdkchan commented May 7, 2023

I think we should probably wait for Github to add arm64 runners to run the tests for that as well.

We don't know when that will happen and sooner or later we will need those builds. So I don't think we should wait for that. Most of the tests are CPU tests that wouldn't work on macOS anyway right now, since Unicorn doesn't play nicely with .NET on arm64 Mac due to the JIT memory restrictions.

@TSRBerry
Copy link
Member

TSRBerry commented May 7, 2023

I may have worded that badly, I just meant we should not add our own runner here to run arm64 tests right now and instead wait for Github to add support for arm64 runners.

@TSRBerry
Copy link
Member

TSRBerry commented May 7, 2023

Apple M1 runners are planned for Q4 2023: https://github.com/orgs/github/projects/4247?pane=issue&itemId=5944419

(Thanks @Candygoblen123 for letting me know!)

@ingangi
Copy link

ingangi commented May 8, 2023

Hi @TSRBerry @gdkchan
If I compile the latest code on M1 macbook pro, can I get the same features as the windows/linux version, or does mac have an independent branch, and I need to wait for your merge code?

@TSRBerry
Copy link
Member

TSRBerry commented May 8, 2023

#4062

You get the same features as Windows/Linux, but that won't be enough to make everything work as on the release build. You can see the upstreaming progress in the issue above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request infra Related to the project infrastructure os:macOS An issue or feature request exclusively relating to macOS
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants