hybrid-array: use From for Array<->[T; N] reference conversions
#1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...instead of `AsRef`/`AsMut`, which allows inference to work for those traits. Notably `[T; N]` doesn't impl `AsRef`/`AsMut` for itself, only for slices, so this is more consistent.
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2023
These were removed in #1026 for more consistency with core arrays. However, `generic-array` provides these impls, which makes removing them problematic when migrating `generic-array`-based code, so it's easier to keep them around, even if it breaks inference due to overlapping impls.
tarcieri
added a commit
that referenced
this pull request
Dec 31, 2023
These were removed in #1026 for more consistency with core arrays. However, `generic-array` provides these impls, which makes removing them problematic when migrating `generic-array`-based code, so it's easier to keep them around, even if it breaks inference due to overlapping impls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of
AsRef/AsMut, which allows inference to work for those traits.Notably
[T; N]doesn't implAsRef/AsMutfor itself, only for slices, so this is more consistent.