Implement as_flattened{_mut}() for Array<Array<>>
#86
+90
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Sep 12, 2024
|
NOTE: the SAFETY comments could probably include some more information regarding the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of
as_flattenedandas_flattened_mutfor nestedArraytypes to make it easier to operate on nestedArrays. Inspiration drawn from theas_flattened{_mut}implementations on[[T; N]](i.e. for the slice primitive).Note:
Array<[T; N], U>already implements these functions as it is transparent to&[[T; N]].[Array<T, U>]does not implement these functions and we can't implement them this way without a new local trait. Doesn't really seem necessary though.