Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spki: Adds a SignatureBitStringEncoding trait #1047

Merged
merged 1 commit into from
May 4, 2023

Conversation

baloo
Copy link
Member

@baloo baloo commented May 4, 2023

This is used to differentiate the different encoding for signatures as x509 related structures rely on BitString encoding of the various signatures.

This is mostly used as a marker trait to ensure misuse resistance of the API.

See #1043 #1041

spki/Cargo.toml Outdated Show resolved Hide resolved
spki/src/traits.rs Outdated Show resolved Hide resolved
@baloo baloo force-pushed the baloo/spki/bitstring-signature branch from 3c0839d to f77783f Compare May 4, 2023 17:50
This is used to differentiate the different encoding for signatures as
x509 related structures rely on `BitString` encoding of the various
signatures.

This is mostly used as a marker trait to ensure misuse resistance of the
API.
@baloo baloo force-pushed the baloo/spki/bitstring-signature branch from f77783f to e467cef Compare May 4, 2023 18:55
@tarcieri tarcieri merged commit 82a6ed5 into RustCrypto:master May 4, 2023
57 checks passed
@baloo baloo deleted the baloo/spki/bitstring-signature branch May 4, 2023 20:48
@baloo
Copy link
Member Author

baloo commented May 4, 2023

@tarcieri do you mind if I proceed with a release 0.7.2?

baloo added a commit to baloo/formats that referenced this pull request May 4, 2023
Added
- `AlgorithmIdentifierWithOid` trait (RustCrypto#986)
- `SignatureBitStringEncoding` trait (RustCrypto#1047)

Changed
-  Bump `hex-literal` to v0.4.1 (RustCrypto#999)
@baloo baloo mentioned this pull request May 4, 2023
@tarcieri
Copy link
Member

tarcieri commented May 4, 2023

Sure, sounds good

baloo added a commit to baloo/formats that referenced this pull request May 4, 2023
Added
- `AlgorithmIdentifierWithOid` trait (RustCrypto#986)
- `SignatureBitStringEncoding` trait (RustCrypto#1047)

Changed
-  Bump `hex-literal` to v0.4.1 (RustCrypto#999)
baloo added a commit that referenced this pull request May 4, 2023
Added
- `AlgorithmIdentifierWithOid` trait (#986)
- `SignatureBitStringEncoding` trait (#1047)

Changed
-  Bump `hex-literal` to v0.4.1 (#999)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants