add comment to specify the rand version #473
Merged
+10
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Its-Just-Nans can you rebase? |
Its-Just-Nans
force-pushed
the
document-rand-version
branch
from
d18a829 to
e27e99c
Compare
Yes, done |
tarcieri
approved these changes
Feb 14, 2025
dignifiedquire
approved these changes
Feb 14, 2025
|
This PR should be probably merged into the |
Its-Just-Nans
force-pushed
the
document-rand-version
branch
from
e27e99c to
cdc5367
Compare
|
I've updated the base branch |
|
Hm. Should we merge it regardless of the CI failures? |
|
Not sure what broke the build, but maybe we should fix it |
|
Hi The commit "Fix CI" 3f83141 fixed the CI by removing unused import (also by updating cargo.lock) |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
This PR is not super useful BUT can be useful.
Of course this PR should be kind of reversed/updated when the rand 0.9 will be supported
Linked to
rand_corev0.9 support #466Feel free to close if not useful enough to be merged