Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Pkcs1v15Sign::new_raw to Pkcs1v15Sign::new_unprefixed #293

Merged
merged 1 commit into from
Apr 17, 2023

Conversation

tarcieri
Copy link
Member

Following #290, which amended pkcs1v15::SigningKey, this commit makes a corresponding change to Pkcs1v15Sign so the method name is consistent with SigningKey::new_unprefixed.

cc @lumag

Following #290, which amended `pkcs1v15::SigningKey`, this commit makes
a corresponding change to `Pkcs1v15Sign` so the method name is
consistent with `SigningKey::new_unprefixed`
@lumag
Copy link
Contributor

lumag commented Apr 16, 2023

LGTM (please note that I don't use padding schemas).
Maybe @dignifiedquire does?

@tarcieri tarcieri merged commit 891a4ca into master Apr 17, 2023
9 checks passed
@tarcieri tarcieri deleted the pkcs1v15/new-unprefixed-consistency-fixup branch April 17, 2023 12:40
@tarcieri tarcieri mentioned this pull request Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants