Merge pull request #238 from RightCapitalHQ/feature/update-deprecated-eslint-react-rules

feat: update deprecated `no-useless-custom-hooks` rule name from `@eslint-react/eslint-plugin`

Author: frantic1048

change/@rightcapital-eslint-config-d9c67318-a754-4d08-9c1b-223ce2a02ddf.json

@@ -0,0 +1,7 @@
+{
+  "comment": "feat: update deprecated `no-useless-custom-hooks` rule name from `@eslint-react/eslint-plugin`",
+  "type": "patch",
+  "packageName": "@rightcapital/eslint-config",
+  "email": "im@pyonpyon.today",
+  "dependentChangeType": "patch"
+}

packages/eslint-config/src/config/mixin/react.ts

@@ -61,7 +61,7 @@ const config: TSESLint.FlatConfig.ConfigArray = [
       '@eslint-react/hooks-extra/no-direct-set-state-in-use-effect': 'off',
 
       // MEMO: Too opinionated thus we disable it
-      '@eslint-react/hooks-extra/no-useless-custom-hooks': 'off',
+      '@eslint-react/hooks-extra/no-unnecessary-use-prefix': 'off',
 
       // A11y
       // Enforce that all elements that require alternative text have meaningful information

specs/eslint-configs/__snapshots__/presets.test.mts.snap

@@ -2147,7 +2147,7 @@ exports[`Resolved config matches snapshot > typescript.ts 2`] = `
       "simple-import-sort:eslint-plugin-simple-import-sort@12.1.1",
       "@stylistic",
       "@typescript-eslint:@typescript-eslint/eslint-plugin@8.26.1",
-      "@rightcapital:@rightcapital/eslint-plugin@42.1.0",
+      "@rightcapital:@rightcapital/eslint-plugin",
 -     "unused-imports:unused-imports",
     ],
     "rules": Object {
@@ -3379,9 +3379,6 @@ exports[`Resolved config matches snapshot > typescript-react.tsx 1`] = `
       0,
     ],
     "@eslint-react/hooks-extra/no-unnecessary-use-prefix": [
-      1,
-    ],
-    "@eslint-react/hooks-extra/no-useless-custom-hooks": [
       0,
     ],
     "@eslint-react/hooks-extra/prefer-use-state-lazy-initialization": [
@@ -4930,14 +4927,14 @@ exports[`Resolved config matches snapshot > typescript-react.tsx 2`] = `
       "simple-import-sort:eslint-plugin-simple-import-sort@12.1.1",
       "@stylistic",
       "@typescript-eslint:@typescript-eslint/eslint-plugin@8.26.1",
-      "@rightcapital:@rightcapital/eslint-plugin@42.1.0",
+      "@rightcapital:@rightcapital/eslint-plugin",
 -     "unused-imports:unused-imports",
       "@eslint-react:eslint-plugin-react-x@1.36.1",
       "@eslint-react/dom:eslint-plugin-react-dom@1.36.1",
       "@eslint-react/web-api:eslint-plugin-react-web-api@1.36.1",
       "@eslint-react/debug:eslint-plugin-react-debug@1.36.1",
       "@eslint-react/hooks-extra:eslint-plugin-react-hooks-extra@1.36.1",
-@@ -1558,11 +1557,11 @@
+@@ -1555,11 +1554,11 @@
       ],
       "@typescript-eslint/no-unused-expressions": Array [
         2,
@@ -4950,7 +4947,7 @@ exports[`Resolved config matches snapshot > typescript-react.tsx 2`] = `
         },
       ],
       "@typescript-eslint/no-use-before-define": Array [
-@@ -2682,13 +2681,10 @@
+@@ -2679,13 +2678,10 @@
       ],
       "unicorn/prefer-node-protocol": Array [
         2,

specs/eslint-configs/presets.test.mts

@@ -60,9 +60,8 @@ const parsedConfigs = await getParsedConfig();
 describe('Resolved config matches snapshot', () => {
   for (const [file, config, editorModeConfig] of parsedConfigs) {
     test(file, () => {
-      expect({
-        ...config,
-
+      const trimConfigForSnapshot = (rawConfig) => ({
+        ...rawConfig,
         // These fields contain unnecessary information for snapshot
         parser: '<OMITTED>',
         plugins: '<OMITTED>',
@@ -71,10 +70,32 @@ describe('Resolved config matches snapshot', () => {
           ...config.languageOptions,
           parser: '<OMITTED>',
         },
-      }).toMatchSnapshot();
+      });
+      expect(trimConfigForSnapshot(config)).toMatchSnapshot();
 
+      const trimConfigForDiff = (rawConfig) => ({
+        ...rawConfig,
+        // These fields contain unnecessary information for diff
+        plugins: rawConfig.plugins.map((pluginName) =>
+          pluginName.replace(
+            /**
+             * We have to strip the version part of our plugin name (the plugin is in this monorepo)
+             *
+             * from:  "@rightcapital:@rightcapital/eslint-plugin@42.1.0"
+             * to:    "@rightcapital:@rightcapital/eslint-plugin"
+             *
+             * Since every time we publish a new version:
+             * 1. snapshot references to existing old version of @rightcapital/eslint-plugin
+             * 2. new version of @rightcapital/eslint-plugin published
+             * 3. new snapshot test will reference to the new version, test fails
+             */
+            /(?<=@rightcapital\/eslint-plugin)@.*$/,
+            '',
+          ),
+        ),
+      });
       expect(
-        diff(config, editorModeConfig, {
+        diff(trimConfigForDiff(config), trimConfigForDiff(editorModeConfig), {
           aAnnotation: 'Editor mode: false',
           bAnnotation: 'Editor mode: true',
           expand: false,