Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add tabs.onRemoved and tabs.onCreated mocks #1

Merged
merged 2 commits into from Apr 22, 2024

Conversation

RickyMarou
Copy link
Owner

I took a (very) quick stab at adding those missing methods:

I followed the existing pattern that exists with onUpdated, i.e. I did not implement mock functionalities to make the addListener, removeListener and hasListener work (we could for an example keep track of the functions added as listeners and return correct values in hasListener), but simply mocked them with jest.fn().

@RickyMarou RickyMarou merged commit 353f10e into main Apr 22, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant