Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add version ranges for react-redux 8.x.x and 9.x.x #2159

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

regexowl
Copy link
Contributor

This adds versions 8.x.x and 9.x.x to the react-redux peer dependency for the following packages:

  • components
  • notifications
  • utils

@regexowl
Copy link
Contributor Author

Was running into dependency conflicts with react-redux version 9.2.0 when trying to bump packages above. Hoping this might resolve the problem.

@regexowl regexowl changed the title Add version ranges for react-redux 8.x.x and 9.x.x peerDependencies: Add version ranges for react-redux 8.x.x and 9.x.x Jan 27, 2025
@regexowl regexowl changed the title peerDependencies: Add version ranges for react-redux 8.x.x and 9.x.x Add version ranges for react-redux 8.x.x and 9.x.x Jan 27, 2025
@regexowl regexowl changed the title Add version ranges for react-redux 8.x.x and 9.x.x fix: Add version ranges for react-redux 8.x.x and 9.x.x Feb 3, 2025
@regexowl
Copy link
Contributor Author

regexowl commented Feb 3, 2025

@regexowl regexowl changed the title fix: Add version ranges for react-redux 8.x.x and 9.x.x fix: add version ranges for react-redux 8.x.x and 9.x.x Feb 3, 2025
@AsToNlele
Copy link
Contributor

Hi @regexowl, I had the same idea here #2165, could you add remediations as well

This adds versions 8.x.x and 9.x.x to the react-redux peer dependency for the following packages:
- components
- notifications
- utils
- remediations
@regexowl
Copy link
Contributor Author

regexowl commented Feb 6, 2025

Hi @regexowl, I had the same idea here #2165, could you add remediations as well

Hey @AsToNlele sure, I've added ranges there!

Copy link
Member

@bastilian bastilian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @regexowl for updating the ranges!

@regexowl
Copy link
Contributor Author

Thank you @bastilian!

@bastilian bastilian merged commit 5d32d44 into RedHatInsights:master Feb 10, 2025
8 checks passed
@regexowl regexowl deleted the add-version-ranges branch February 10, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants