Silence unused and platform type warnings #179
Merged
+57
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshfriend
force-pushed
the
fix-warnings
branch
2 times, most recently
from
032f6d6 to
b42888d
Compare
|
I also added annotations to the extensions added in #185 that were missing them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This suppresses warnings in IntelliJ about methods being unused since this is a library and someone is probably using them.
Also shuts off the "has platform type" warning which is what highlights things like
Observable.switchMap()because they do not have@NonNullannotations, but we know that they do not return null.