Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI failures with pytest 8 #100

Closed
RMeli opened this issue Feb 2, 2024 · 0 comments · Fixed by #101
Closed

CI failures with pytest 8 #100

RMeli opened this issue Feb 2, 2024 · 0 comments · Fixed by #101

Comments

@RMeli
Copy link
Owner

RMeli commented Feb 2, 2024

For a few days, CI has been failing consistently. Different platforms, different molecular I/O library, different network libraries.

The most notable difference between the last green CI and the failing CI is pytest, gone from 7.4.4 to 8.0.0.

Looking at the failure, it appears that the error message raised and the one captured by pytest do not match:

E       Failed: DID NOT WARN. No warnings of type (<class 'UserWarning'>,) matching the regex were emitted.
E        Regex: No atomic number information stored on nodes.
E        Emitted warnings: [ UserWarning('No atomic property information stored on nodes. Node matching is not performed...')].

It appears that some of the error messages were not updated in #64. However, this failed silently because of pytest-dev/pytest#9288.

Since pyrest=8.0.0, warns() [...] re-emits unmatched warnings when the context closes – previously it would consume all warnings, hiding those that were not matched by the function.

@RMeli RMeli self-assigned this Feb 2, 2024
@RMeli RMeli closed this as completed in #101 Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant