Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnest rustworkx tests folder #1062

Merged
merged 2 commits into from
Jan 21, 2024
Merged

Unnest rustworkx tests folder #1062

merged 2 commits into from
Jan 21, 2024

Conversation

IvanIsCoding
Copy link
Collaborator

This shortens our folder structure for rustworkx tests after #1004. Which is what we had on the retworkx days

mtreinish
mtreinish approved these changes Jan 21, 2024
View reviewed changes
Copy link
Member

@mtreinish mtreinish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure this makes sense to me. It didn't really bother me to have a layer of nesting, but I could see it being annoying, especially as we don't have any other test suites in the directory.

@coveralls
Copy link

coveralls commented Jan 21, 2024 •
edited

Pull Request Test Coverage Report for Build 7602118216

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 95.942%
Totals Coverage Status
Change from base Build 7602107468: 0.0%
Covered Lines: 16100
Relevant Lines: 16781
💛 - Coveralls

@mtreinish mtreinish added the automerge Queue a approved PR for merging label Jan 21, 2024
@mergify mergify bot merged commit 87cb008 into Qiskit:main Jan 21, 2024
27 checks passed
@IvanIsCoding IvanIsCoding deleted the unnest-tests branch January 28, 2024 01:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtreinish mtreinish mtreinish approved these changes

Assignees
No one assigned
Labels
automerge Queue a approved PR for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@IvanIsCoding @coveralls @mtreinish