Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format synthesis docs (backport #11755) #11806

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 15, 2024

This is an automatic backport of pull request #11755 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Format synthesis docs.

* Apply suggestions from Jake's code review

Co-authored-by: Jake Lishman <jake@binhbar.com>

* Apply rest of review comments

* Fix lint, latexify ~

* Apply suggestions from code review

* Revert bug in TwoQubitWeylfSimabmbEquiv

* Apply inline suggestions from Julien's code review

Co-authored-by: Julien Gacon <gaconju@gmail.com>

* Finish applying Julien's suggestions

* Apply suggestions from Shelly's code review

* inline typehints for synth docs

* Update qiskit/synthesis/clifford/clifford_decompose_ag.py

Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com>

* Apply review comments from Shelly

* Make lint happy?

* Fix black

* Remove unnecessary indentation

* Fix backslash in non-raw string

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Co-authored-by: Julien Gacon <gaconju@gmail.com>
Co-authored-by: Julien Gacon <jules.gacon@googlemail.com>
Co-authored-by: Evgenii Zheltonozhskii <zheltonozhskiy@gmail.com>
(cherry picked from commit 694de7c)
@qiskit-bot
Copy link
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core
  • @ikkoham
  • @levbishop

@github-actions github-actions bot added documentation Something is not clear or an error documentation priority: low Changelog: None Do not include in changelog labels Feb 15, 2024
@github-actions github-actions bot added this to the 1.0.0 milestone Feb 15, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build 7909856220

Details

  • 0 of 57 (100.0%) changed or added relevant lines in 19 files are covered.
  • 35 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 89.191%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.81%
crates/qasm2/src/lex.rs 4 91.94%
crates/qasm2/src/parse.rs 30 95.77%
Totals Coverage Status
Change from base Build 7909506477: -0.04%
Covered Lines: 58835
Relevant Lines: 65965

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Feb 15, 2024
Merged via the queue into stable/1.0 with commit ffffdea Feb 15, 2024
14 checks passed
@mergify mergify bot deleted the mergify/bp/stable/1.0/pr-11755 branch February 15, 2024 03:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog documentation Something is not clear or an error documentation priority: low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants