Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qiskit-terra to qiskit in README.md #11801

Merged
merged 5 commits into from Feb 15, 2024
Merged

Conversation

1ucian0
Copy link
Member

@1ucian0 1ucian0 commented Feb 14, 2024

The badges in the readme are pointing to qiskit-terra

@1ucian0 1ucian0 requested a review from a team as a code owner February 14, 2024 21:04
@qiskit-bot
Copy link
Collaborator

One or more of the the following people are requested to review this:

  • @Qiskit/terra-core

Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting it!

README.md Outdated Show resolved Hide resolved
README.md Outdated
![PyPI - Python Version](https://img.shields.io/pypi/pyversions/qiskit)
[![Minimum rustc 1.70](https://img.shields.io/badge/rustc-1.70+-blue.svg)](https://rust-lang.github.io/rfcs/2495-min-rust-version.html)
[![Downloads](https://static.pepy.tech/badge/qiskit-terra)](https://pepy.tech/project/qiskit-terra)<!--- long-description-skip-end -->
[![Downloads](https://static.pepy.tech/badge/qiskit)](https://pepy.tech/project/qiskit)<!--- long-description-skip-end -->
[![DOI](https://zenodo.org/badge/161550823.svg)](https://zenodo.org/badge/latestdoi/161550823)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine this Zenodo DOI points to the wrong place now as well?

@coveralls
Copy link

coveralls commented Feb 14, 2024

Pull Request Test Coverage Report for Build 7914403084

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 104 unchanged lines in 19 files lost coverage.
  • Overall coverage increased (+0.02%) to 89.231%

Files with Coverage Reduction New Missed Lines %
qiskit/synthesis/clifford/clifford_decompose_ag.py 1 98.72%
qiskit/synthesis/clifford/clifford_decompose_full.py 1 87.5%
qiskit/synthesis/linear/cnot_synth.py 1 98.0%
qiskit/synthesis/clifford/clifford_decompose_greedy.py 2 98.88%
qiskit/synthesis/linear/linear_depth_lnn.py 2 98.33%
qiskit/synthesis/stabilizer/stabilizer_decompose.py 2 96.83%
qiskit/synthesis/unitary/qsd.py 2 97.52%
crates/qasm2/src/lex.rs 3 91.94%
qiskit/synthesis/clifford/clifford_decompose_bm.py 3 97.83%
qiskit/synthesis/cnotdihedral/cnotdihedral_decompose_general.py 3 96.05%
Totals Coverage Status
Change from base Build 7906377610: 0.02%
Covered Lines: 58863
Relevant Lines: 65967

💛 - Coveralls

@jakelishman jakelishman added documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable Changelog: None Do not include in changelog labels Feb 14, 2024
Eric-Arellano
Eric-Arellano previously approved these changes Feb 14, 2024
@1ucian0 1ucian0 removed documentation Something is not clear or an error documentation stable backport potential The bug might be minimal and/or import enough to be port to stable labels Feb 15, 2024
1ucian0 and others added 2 commits February 15, 2024 10:02
Co-authored-by: Jake Lishman <jake@binhbar.com>
Copy link
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Luciano. I updated the Zenodo DOI to point to https://doi.org/10.5281/zenodo.2583252, which is the tracker for Qiskit/qiskit (a name that no longer contains Terra), rather than the old one which was the tracker for Qiskit/qiskit-metapackage.

@jakelishman jakelishman added the stable backport potential The bug might be minimal and/or import enough to be port to stable label Feb 15, 2024
@jakelishman jakelishman added this pull request to the merge queue Feb 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 15, 2024
@jakelishman jakelishman added this pull request to the merge queue Feb 15, 2024
Merged via the queue into Qiskit:main with commit ffe0019 Feb 15, 2024
12 checks passed
mergify bot pushed a commit that referenced this pull request Feb 15, 2024
* Update qiskit-terra to qiskit in README.md

* rust version

* Update README.md

Co-authored-by: Jake Lishman <jake@binhbar.com>

* Update Zenodo DOI to Qiskit/qiskit

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
(cherry picked from commit ffe0019)
github-merge-queue bot pushed a commit that referenced this pull request Feb 15, 2024
* Update qiskit-terra to qiskit in README.md

* rust version

* Update README.md

Co-authored-by: Jake Lishman <jake@binhbar.com>

* Update Zenodo DOI to Qiskit/qiskit

---------

Co-authored-by: Jake Lishman <jake@binhbar.com>
Co-authored-by: Jake Lishman <jake.lishman@ibm.com>
(cherry picked from commit ffe0019)

Co-authored-by: Luciano Bello <bel@zurich.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: None Do not include in changelog stable backport potential The bug might be minimal and/or import enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants