Add BaseSamplerV2 #11529
Add BaseSamplerV2 #11529
Conversation
chriseclectic
added
priority: high
mod: primitives
chriseclectic
requested review from
ikkoham,
t-imamichi and
a team
as code owners
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 7547884544
💛 - Coveralls |
chriseclectic
force-pushed
the
basesampler-v2
branch
from
f84a9c3
to
c87b081
Compare
| @@ -200,3 +258,38 @@ def parameters(self) -> tuple[ParameterView, ...]: | |||
| List of the parameters in each quantum circuit. | |||
| """ | |||
| return tuple(self._parameters) | |||
|
|
|||
|
|
|||
| BaseSampler = BaseSamplerV1 | |||
There was a problem hiding this comment.
@jakelishman Is this the sort of thing we should have a from __future__ import <what?> so that BaseSampler gets set to BaseSamplerV2 instead? And that if you import BaseSampler without this import it raises a deprecation warning of some sort using the same trick you used in the other PRs and returns BaseSamplerV1 for it in those cases?
There was a problem hiding this comment.
I guess for 1.0 we might want a future deprecation warning rather than actual deprecation warning for the V1 primitives, and then the actual warning on 1.1?
|
Moved shots to |
| Args: | ||
| pubs: An iterable of pub-like objects. For example, a list of circuits | ||
| or tuples ``(circuit, parameter_values)``. | ||
| shots: The total number of shots to sample for each :class:`.SamplerPub`. |
There was a problem hiding this comment.
If SamplerV2 has an execution option and the number of shots of the execution option and that of run method differ, I guess that of run will be used. Am I correct?
E.g.,
sampler = SamplerV2(options={"execution": {"shots": 10}})
result = sampler.run([circuit], shots=20).result()
# `result` contains 20 samples instead of 10 samples.There was a problem hiding this comment.
Yes, in this situation the kwargs of run takes precedence over execution.shots. The latter should be thought of as the default value when run gets None.
| raise ValueError("shots must be non-negative") | ||
|
|
||
| if isinstance(pub, SamplerPub): | ||
| if pub.shots is None and shots is not None: |
There was a problem hiding this comment.
I guess shots of this method is used as a default value not to overwrite the existing pub.shots.
There was a problem hiding this comment.
That's right, pub.shots takes precedence.
Taken from 11264. Removes Options and adds `shots` attributes to BaseSamplerV2 Co-Authored-By: Takashi Imamichi <31178928+t-imamichi@users.noreply.github.com> Co-Authored-By: Ian Hincks <2229105+ihincks@users.noreply.github.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
chriseclectic
force-pushed
the
basesampler-v2
branch
from
fcd0916
to
4e56f1e
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Summary
Adds BaseSaamplerV2 base class for V2 Sampler primitives
Depends on #11524
Details and comments
This splits out the base classes in from #11264 and makes the following changes
shotsattributesrunkwarg to BaseSamplerV2shotstoSamplerPubSee Add BaseEstimatorV2 #11527 for motivation for these changes.