Add support for Python 3.12 #11262
Merged
Add support for Python 3.12 #11262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. Fixes: Qiskit#10887
mtreinish
added
the
Changelog: New Feature
|
One or more of the the following people are requested to review this:
|
Pull Request Test Coverage Report for Build 6947252053
💛 - Coveralls |
mtreinish
added
the
stable backport potential
In Python 3.12 `datetime.datetime.utcnow()` has been deprecated, being replaced by: `datetime.datetime.now(datetime.UTC)`. This commit updates the usage of `utcnow()` to follow the new convention.
The recommended alternative for using utcnow() in the deprecation warnings emitted by Python 3.12 are not compatible with Python 3.8. The datetime.UTC alias was not added to Python until Python 3.11. To ensure that the code is compatible with Python < 3.11 this commit updates all the usage of datetime.UTC to use datetime.timezone.utc instead, which is what datetime.UTC aliases to in Python >=3.11.
|
I think this should be good to go now, at least it passes locally. My only concern is we'll hit the same stability issue with unitary synthesis on the newer numpy that led to #11232. But to support 3.12 we need to use a newer version of numpy. |
jakelishman
previously approved these changes
Nov 17, 2023
| online_date=datetime.datetime.utcnow(), | ||
| online_date=datetime.datetime.now(datetime.timezone.utc), |
There was a problem hiding this comment.
I was confused why I hadn't seen and fixed this when I was doing the initial Python 3.12 testing, but then I remembered that symengine didn't have wheels at the time and we had Numpy/Scipy problems, so I'd not got all the way.
|
I've been rerunning the tests and managed to trigger the test failure on the 3rd run: https://dev.azure.com/qiskit-ci/qiskit/_build/results?buildId=51680&view=logs&j=783cd8ce-45d0-52b9-fbe2-d8b6f5c36b94&t=f6ef7ac4-a492-580b-ed69-1d6c3306a466&l=22108 I think we need to get to the bottom of this instability issue before we can merge this, otherwise we'll likely block ci in practical terms because of these failures. |
|
Unblocked by the merge of #11307. |
jakelishman
approved these changes
Nov 23, 2023
mergify bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
* Add support for Python 3.12 Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. Fixes: #10887 * Add release note * Avoid deprecated `datetime.datetime.utcnow()` usage In Python 3.12 `datetime.datetime.utcnow()` has been deprecated, being replaced by: `datetime.datetime.now(datetime.UTC)`. This commit updates the usage of `utcnow()` to follow the new convention. * Adjust UTC usage to support Python 3.8 The recommended alternative for using utcnow() in the deprecation warnings emitted by Python 3.12 are not compatible with Python 3.8. The datetime.UTC alias was not added to Python until Python 3.11. To ensure that the code is compatible with Python < 3.11 this commit updates all the usage of datetime.UTC to use datetime.timezone.utc instead, which is what datetime.UTC aliases to in Python >=3.11. (cherry picked from commit 5a5c9e3) # Conflicts: # requirements.txt
jakelishman
pushed a commit
that referenced
this pull request
Nov 23, 2023
* Add support for Python 3.12 Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. Fixes: #10887 * Add release note * Avoid deprecated `datetime.datetime.utcnow()` usage In Python 3.12 `datetime.datetime.utcnow()` has been deprecated, being replaced by: `datetime.datetime.now(datetime.UTC)`. This commit updates the usage of `utcnow()` to follow the new convention. * Adjust UTC usage to support Python 3.8 The recommended alternative for using utcnow() in the deprecation warnings emitted by Python 3.12 are not compatible with Python 3.8. The datetime.UTC alias was not added to Python until Python 3.11. To ensure that the code is compatible with Python < 3.11 this commit updates all the usage of datetime.UTC to use datetime.timezone.utc instead, which is what datetime.UTC aliases to in Python >=3.11. (cherry picked from commit 5a5c9e3)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 23, 2023
* Add support for Python 3.12 Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. Fixes: #10887 * Add release note * Avoid deprecated `datetime.datetime.utcnow()` usage In Python 3.12 `datetime.datetime.utcnow()` has been deprecated, being replaced by: `datetime.datetime.now(datetime.UTC)`. This commit updates the usage of `utcnow()` to follow the new convention. * Adjust UTC usage to support Python 3.8 The recommended alternative for using utcnow() in the deprecation warnings emitted by Python 3.12 are not compatible with Python 3.8. The datetime.UTC alias was not added to Python until Python 3.11. To ensure that the code is compatible with Python < 3.11 this commit updates all the usage of datetime.UTC to use datetime.timezone.utc instead, which is what datetime.UTC aliases to in Python >=3.11. (cherry picked from commit 5a5c9e3) Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
FabianBrings
pushed a commit
to FabianBrings/qiskit
that referenced
this pull request
Nov 27, 2023
* Add support for Python 3.12 Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. Fixes: Qiskit#10887 * Add release note * Avoid deprecated `datetime.datetime.utcnow()` usage In Python 3.12 `datetime.datetime.utcnow()` has been deprecated, being replaced by: `datetime.datetime.now(datetime.UTC)`. This commit updates the usage of `utcnow()` to follow the new convention. * Adjust UTC usage to support Python 3.8 The recommended alternative for using utcnow() in the deprecation warnings emitted by Python 3.12 are not compatible with Python 3.8. The datetime.UTC alias was not added to Python until Python 3.11. To ensure that the code is compatible with Python < 3.11 this commit updates all the usage of datetime.UTC to use datetime.timezone.utc instead, which is what datetime.UTC aliases to in Python >=3.11.
ElePT
pushed a commit
to ElePT/qiskit-ibm-runtime
that referenced
this pull request
Dec 8, 2023
* Add support for Python 3.12 Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release. Fixes: Qiskit/qiskit#10887 * Add release note * Avoid deprecated `datetime.datetime.utcnow()` usage In Python 3.12 `datetime.datetime.utcnow()` has been deprecated, being replaced by: `datetime.datetime.now(datetime.UTC)`. This commit updates the usage of `utcnow()` to follow the new convention. * Adjust UTC usage to support Python 3.8 The recommended alternative for using utcnow() in the deprecation warnings emitted by Python 3.12 are not compatible with Python 3.8. The datetime.UTC alias was not added to Python until Python 3.11. To ensure that the code is compatible with Python < 3.11 this commit updates all the usage of datetime.UTC to use datetime.timezone.utc instead, which is what datetime.UTC aliases to in Python >=3.11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Python 3.12.0 was released on 10-02-2023, this commit marks the start of support for Python 3.12 in Qiskit. It adds the supported Pythonv ersion in the package metadata and updates the CI configuration to run test jobs on Python 3.12 and build Python 3.12 wheels on release.
Details and comments
Fixes: #10887