Update and expand DAGDependency drawer

[enavarro51]

Summary

Fixes #9066

Details and comments

This PR updates the DAGDependency section of the qiskit/visualization/dag_drawer.py.

• The node.qargs and node.cargs have been added to each node display to indicate which qubits and clbits the instruction acts on.
• If an instruction has a condition, it will be displayed
• The colors have been changed to more closely match those of the DAGCircuit drawings.

This circuit

bits = [Qubit(), Clbit()]
qr = QuantumRegister(4, 'qr')
cr = ClassicalRegister(4, 'cr')
qc = QuantumCircuit(qr, bits, cr)
qc.h(0)
qc.cx(0, 1)
qc.cx(0, 2)
qc.cx(0, 3)
qc.x(3).c_if(cr[1], 1)
qc.h(3)
qc.x(4)
qc.barrier(0, 1)
qc.measure(0, 0)
print(qc)
dag = circuit_to_dagdependency(qc)
dag.draw()

produces this circuit drawing

      ┌───┐                 ░       ┌─┐
qr_0: ┤ H ├──■────■────■────░───────┤M├
      └───┘┌─┴─┐  │    │    ░       └╥┘
qr_1: ─────┤ X ├──┼────┼────░────────╫─
           └───┘┌─┴─┐  │    ░        ║ 
qr_2: ──────────┤ X ├──┼─────────────╫─
                └───┘┌─┴─┐┌───┐┌───┐ ║ 
qr_3: ───────────────┤ X ├┤ X ├┤ H ├─╫─
      ┌───┐          └───┘└─╥─┘└───┘ ║ 
   4: ┤ X ├─────────────────╫────────╫─
      └───┘                 ║        ║ 
   0: ══════════════════════■════════╩═
                                       
cr: 4/═════════════════════════════════
                                       

and this graph drawing

[qiskit-bot]

One or more of the the following people are requested to review this:

• @enavarro51
• @Qiskit/terra-core

[coveralls]

Pull Request Test Coverage Report for Build 6635363212

• 1 of 24 (4.17%) changed or added relevant lines in 1 file are covered.
• 25 unchanged lines in 4 files lost coverage.
• Overall coverage decreased (-0.04%) to 86.88%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
qiskit/visualization/dag_visualization.py	1	24	4.17%

Files with Coverage Reduction	New Missed Lines	%
crates/qasm2/src/expr.rs	1	93.76%
qiskit/visualization/dag_visualization.py	1	9.57%
crates/qasm2/src/lex.rs	5	90.4%
crates/qasm2/src/parse.rs	18	96.67%

Totals
Change from base Build 6631999916:	-0.04%
Covered Lines:	73952
Relevant Lines:	85120

---

💛 - Coveralls

[jakelishman]

In general, this looks a completely clear win in usability to me. I haven't used DAGDependency much though, so it'd be good to get a second opinion. @alexanderivrii, does the new output format look good to you here?

Can we have a "feature" release note for this improvement to the drawers as well?

[jakelishman]

This one isn't a DAGDependency, right?

[enavarro51]

Right. I was going to use a 1% diff on the image tests, but this one was at 6%, so I thought I'd update the reference image. Turns out after doing this it was still at 6% and the DAGDependency image was at 8% on the CI run. So I don't know what the difference is between the fonts, image libraries, etc. between my local and CI. I have the recommended version of graphviz. So we could just leave the old one.

[jakelishman]

I mean, the new one looks more like it's intended and it passes CI, so I'm fine leaving it.

[enavarro51]

I'll add a reno.

[enavarro51]

Reno added in 53381b3.

[alexanderivrii]

Thanks @enavarro51, I really like the new output. The code changes look good as well.