Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add qpy support for Cliffords and AnnotatedOperations #11088

Closed
alexanderivrii opened this issue Oct 23, 2023 · 1 comment · Fixed by #11505
Closed

Add qpy support for Cliffords and AnnotatedOperations #11088

alexanderivrii opened this issue Oct 23, 2023 · 1 comment · Fixed by #11505
Assignees
Labels
type: feature request New feature or request
Milestone

Comments

@alexanderivrii
Copy link
Contributor

What should we add?

Quoting correspondence with @mtreinish:

This is a similar issue to QPY too (it was something I mentioned in review on the AnnotatedOperation but forgot to follow up with a PR for). We need special handling for the operation types to work with qpy. I think the last time I tested with a clifford it crashed.

@alexanderivrii alexanderivrii added the type: feature request New feature or request label Oct 23, 2023
@alexanderivrii alexanderivrii added this to the 0.46.0 milestone Oct 23, 2023
@alexanderivrii alexanderivrii self-assigned this Oct 23, 2023
@alexanderivrii
Copy link
Contributor Author

alexanderivrii commented Jan 5, 2024

Adding QPY support for Cliffords is done #11495, where the Clifford's tableau is stored in instruction_params on dumping, and is used to recreate the Clifford on loading.

Adding QPY support for annotated operations is done in #11505 (which is implemented on top of #11495), where the base operation is stored as a custom instruction while the list of modifiers is stored in instruction_params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature request New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants