Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom header not being sent #1592

Merged
merged 3 commits into from
Apr 9, 2024
Merged

Custom header not being sent #1592

merged 3 commits into from
Apr 9, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Apr 9, 2024

Summary

Fixes a bug added in 36d7c15 that caused custom headers to not be sent in the /jobs api request

Details and comments

Fixes #1508

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Apr 9, 2024
@coveralls
Copy link

coveralls commented Apr 9, 2024

Pull Request Test Coverage Report for Build 8620119519

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 3 of 6 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall first build on custom-header-bug at 83.595%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/api/session.py 3 6 50.0%
Totals Coverage Status
Change from base Build 8620102476: 83.6%
Covered Lines: 6227
Relevant Lines: 7449

💛 - Coveralls

@akihikokuroda
Copy link

@kt474 This fixes the issue. Thanks!
Here is the header and middleware_job_id/0187e965-633a-47f7-a696-efb97edf5053 is what we expected.

X-Qx-Client-Application: qiskit-version-2/qiskit_ibm_runtime-0.22.0,qiskit-1.0.2*/qiskit_ibm_runtime~estimator.py/middleware_job_id/0187e965-633a-47f7-a696-efb97edf5053

@kt474 kt474 marked this pull request as ready for review April 9, 2024 15:45
@kt474 kt474 merged commit cedd81b into Qiskit:main Apr 9, 2024
18 checks passed
@kt474 kt474 deleted the custom-header-bug branch April 9, 2024 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

custom header is not included int the /runtime/jobs request
3 participants