Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decode empty Databin's #1580

Merged
merged 4 commits into from
Apr 12, 2024
Merged

Decode empty Databin's #1580

merged 4 commits into from
Apr 12, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Apr 2, 2024

Summary

Details and comments

Fixes #1566

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Apr 2, 2024
@coveralls
Copy link

coveralls commented Apr 2, 2024 •
edited

Pull Request Test Coverage Report for Build 8662640560

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 83.615%
Totals Coverage Status
Change from base Build 8650442305: 0.0%
Covered Lines: 6236
Relevant Lines: 7458
💛 - Coveralls

ptristan3
ptristan3 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@ptristan3 ptristan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe it would be good to include a test case for the decoder.

@kt474 kt474 requested a review from mberna April 10, 2024 14:55
@jyu00 jyu00 merged commit dcadf81 into Qiskit:main Apr 12, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 approved these changes

@mberna mberna Awaiting requested review from mberna

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ResultDecoder fails when decoding empty DataBin's
4 participants
@kt474 @coveralls @ptristan3 @jyu00