Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use status() for related methods #1568

Merged
merged 9 commits into from
Apr 5, 2024
Merged

Use status() for related methods #1568

merged 9 commits into from
Apr 5, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 28, 2024

Summary

Details and comments

Fixes #1547

@kt474 kt474 added the Changelog: Bugfix Include in the Fixed section of the changelog label Mar 28, 2024
@coveralls
Copy link

coveralls commented Mar 28, 2024 •
edited

Pull Request Test Coverage Report for Build 8573186465

Details

  • 15 of 25 (60.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 83.632%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/runtime_job.py 8 11 72.73%
qiskit_ibm_runtime/runtime_job_v2.py 2 9 22.22%
Totals Coverage Status
Change from base Build 8559101443: -0.02%
Covered Lines: 6213
Relevant Lines: 7429
💛 - Coveralls

gadial
gadial reviewed Apr 1, 2024
View reviewed changes
Copy link
Collaborator

@gadial gadial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, left some minor comments.

qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/runtime_job.py Outdated Show resolved Hide resolved
qiskit_ibm_runtime/base_runtime_job.py Show resolved Hide resolved
qiskit_ibm_runtime/base_runtime_job.py Show resolved Hide resolved
frankharkins
frankharkins approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@frankharkins frankharkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Tested and it works correctly 🙂

qiskit_ibm_runtime/runtime_job.py Show resolved Hide resolved
@kt474 kt474 merged commit e56ab23 into Qiskit:main Apr 5, 2024
20 checks passed
@kt474 kt474 deleted the job-status-refactor branch April 5, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadial gadial gadial left review comments

@frankharkins frankharkins frankharkins approved these changes

Assignees
No one assigned
Labels
Changelog: Bugfix Include in the Fixed section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

job.in_final_state() does not fetch status
4 participants
@kt474 @coveralls @gadial @frankharkins