Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add qctrl validation for Primitives v2 #1550

Merged
merged 12 commits into from
Mar 27, 2024

Conversation

chongyouquan
Copy link
Contributor

@chongyouquan chongyouquan commented Mar 22, 2024

Summary

  • This PR introduces changes to validate inputs for qctrl's primitives v2.

Details and comments

  • Relies on the channel_strategy property
  • Routes parameter validation in Primitives v2 to qctrl's logic if the q-ctrl string is found in the channel_strategy property
  • Implements parameter validation for options in Primitives v2

@CLAassistant
Copy link

CLAassistant commented Mar 22, 2024

CLA assistant check
All committers have signed the CLA.

@chongyouquan chongyouquan changed the title add tests feat: Add qctrl validation for Primitives v2 Mar 22, 2024
@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8459558593

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 33 of 35 (94.29%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.07%) to 83.579%

Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/utils/qctrl.py 25 27 92.59%
Totals Coverage Status
Change from base Build 8455421172: 0.07%
Covered Lines: 6189
Relevant Lines: 7405

💛 - Coveralls

@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Mar 27, 2024
Copy link
Member

@kt474 kt474 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chongyouquan! LGTM

@kt474 kt474 merged commit c582e57 into Qiskit:main Mar 27, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants