Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pretty print options #1538

Merged
merged 5 commits into from
Mar 29, 2024
Merged

Pretty print options #1538

merged 5 commits into from
Mar 29, 2024

Conversation

kt474
Copy link
Member

@kt474 kt474 commented Mar 20, 2024 •
edited

Summary

Added a simple _repr_html_ method to format Options and OptionsV2 if they are printed in a jupyter/vscode cell.

Screenshot 2024-03-26 at 2 13 28 PM

Details and comments

Fixes #1490

@coveralls
Copy link

coveralls commented Mar 20, 2024 •
edited

Pull Request Test Coverage Report for Build 8484403726

Details

  • 4 of 12 (33.33%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.09%) to 83.666%
Changes Missing Coverage Covered Lines Changed/Added Lines %
qiskit_ibm_runtime/options/options.py 2 10 20.0%
Totals Coverage Status
Change from base Build 8473895316: -0.09%
Covered Lines: 6203
Relevant Lines: 7414
💛 - Coveralls

@kt474 kt474 marked this pull request as ready for review March 26, 2024 18:15
@kt474 kt474 added the Changelog: New Feature Include in the Added section of the changelog label Mar 26, 2024
@kt474 kt474 requested a review from ihincks March 26, 2024 18:24
ptristan3
ptristan3 approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@ptristan3 ptristan3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@kt474 kt474 merged commit c34ad93 into Qiskit:main Mar 29, 2024
20 checks passed
@kt474 kt474 deleted the pprint-options-classes branch March 29, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptristan3 ptristan3 ptristan3 approved these changes

@ihincks ihincks Awaiting requested review from ihincks

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement an _html_repr_ for the option classes
3 participants
@kt474 @coveralls @ptristan3