Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hacky fix for Reno removing 0.16+ release notes #1479

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Eric-Arellano
Copy link
Collaborator

Reno stopped including 0.16+ and newer on the stable/0.21 branch and on main, but it still works for stable/0.20. @arnaucasau and I spent two hours trying to debug this and couldn't figure it out.

To unblock getting out release notes for 0.21, we're going to use this hacky workaround to generate two separate release notes. The API generation script in qiskit/documentation will merge back to a single list.

We're going to either investigate more closely what happened later, or switch away from Reno so it doesn't matter. See Qiskit/documentation#978

Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
@Eric-Arellano Eric-Arellano requested a review from kt474 March 6, 2024 18:21
@Eric-Arellano Eric-Arellano added the backport potential The bug might be minimal and/or important enough to be port to stable label Mar 6, 2024
@kt474 kt474 merged commit 3cc23fc into Qiskit:main Mar 6, 2024
20 checks passed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8176887849

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 82.284%

Totals Coverage Status
Change from base Build 8175443887: 0.0%
Covered Lines: 5764
Relevant Lines: 7005

💛 - Coveralls

@Eric-Arellano Eric-Arellano deleted the EA/hack-around-reno branch March 6, 2024 18:34
Eric-Arellano added a commit to Eric-Arellano/qiskit-ibm-runtime that referenced this pull request Mar 6, 2024
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
kt474 pushed a commit that referenced this pull request Mar 6, 2024
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
Eric-Arellano added a commit that referenced this pull request Mar 6, 2024
This is a better fix for Qiskit/documentation#978 than #1479 was. 

The issue with #1479 is release notes for 0.16+ were being put into the 0.15 entry.

This new approach also allows us to move the hacky code we needed in qiskit/documentation. This new file was tested with our API generation script and does the right thing.
Eric-Arellano added a commit to Eric-Arellano/qiskit-ibm-runtime that referenced this pull request Mar 6, 2024
This is a better fix for Qiskit/documentation#978 than Qiskit#1479 was. 

The issue with Qiskit#1479 is release notes for 0.16+ were being put into the 0.15 entry.

This new approach also allows us to move the hacky code we needed in qiskit/documentation. This new file was tested with our API generation script and does the right thing.
kt474 pushed a commit that referenced this pull request Mar 6, 2024
This is a better fix for Qiskit/documentation#978 than #1479 was. 

The issue with #1479 is release notes for 0.16+ were being put into the 0.15 entry.

This new approach also allows us to move the hacky code we needed in qiskit/documentation. This new file was tested with our API generation script and does the right thing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport potential The bug might be minimal and/or important enough to be port to stable
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants