-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hacky fix for Reno removing 0.16+ release notes #1479
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
Eric-Arellano
added
the
backport potential
The bug might be minimal and/or important enough to be port to stable
label
Mar 6, 2024
kt474
approved these changes
Mar 6, 2024
arnaucasau
approved these changes
Mar 6, 2024
Pull Request Test Coverage Report for Build 8176887849Details
💛 - Coveralls |
Eric-Arellano
added a commit
to Eric-Arellano/qiskit-ibm-runtime
that referenced
this pull request
Mar 6, 2024
Loading
Loading status checks…
Co-authored-by: Arnau Casau <47946624+arnaucasau@users.noreply.github.com>
kt474
pushed a commit
that referenced
this pull request
Mar 6, 2024
Eric-Arellano
added a commit
that referenced
this pull request
Mar 6, 2024
Loading
Loading status checks…
This is a better fix for Qiskit/documentation#978 than #1479 was. The issue with #1479 is release notes for 0.16+ were being put into the 0.15 entry. This new approach also allows us to move the hacky code we needed in qiskit/documentation. This new file was tested with our API generation script and does the right thing.
Eric-Arellano
added a commit
to Eric-Arellano/qiskit-ibm-runtime
that referenced
this pull request
Mar 6, 2024
Loading
Loading status checks…
This is a better fix for Qiskit/documentation#978 than Qiskit#1479 was. The issue with Qiskit#1479 is release notes for 0.16+ were being put into the 0.15 entry. This new approach also allows us to move the hacky code we needed in qiskit/documentation. This new file was tested with our API generation script and does the right thing.
kt474
pushed a commit
that referenced
this pull request
Mar 6, 2024
This is a better fix for Qiskit/documentation#978 than #1479 was. The issue with #1479 is release notes for 0.16+ were being put into the 0.15 entry. This new approach also allows us to move the hacky code we needed in qiskit/documentation. This new file was tested with our API generation script and does the right thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reno stopped including 0.16+ and newer on the stable/0.21 branch and on main, but it still works for stable/0.20. @arnaucasau and I spent two hours trying to debug this and couldn't figure it out.
To unblock getting out release notes for 0.21, we're going to use this hacky workaround to generate two separate release notes. The API generation script in qiskit/documentation will merge back to a single list.
We're going to either investigate more closely what happened later, or switch away from Reno so it doesn't matter. See Qiskit/documentation#978