Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression in unescaping backslash in TOC title #1360

Closed
oprypin opened this issue Jul 19, 2023 · 3 comments · Fixed by #1361
Closed

Regression in unescaping backslash in TOC title #1360

oprypin opened this issue Jul 19, 2023 · 3 comments · Fixed by #1361
Labels
bug Bug report. confirmed Confirmed bug report or approved feature request. extension Related to one or more of the included extensions.

Comments

@oprypin
Copy link
Contributor

oprypin commented Jul 19, 2023

Now I found another issue similar to #1358 and I checked that its fix doesn't also fix this one.

Regression in 3.4 - c0f6e5a is the first bad commit

Reproduction code:

import markdown

md = markdown.Markdown(extensions=['toc'])
s = r'''
### hello \[foo]
'''
md.convert(s)
print(md.toc_tokens)

Output before vs after:

[{'level': 3, 'id': 'hello-foo', 'name': 'hello [foo]', 'children': []}]
[{'level': 3, 'id': 'hello-foo', 'name': 'hello \x0291\x03foo]', 'children': []}]
@oprypin
Copy link
Contributor Author

oprypin commented Jul 19, 2023

For some background: I am finding these issues because I check MkDocs against a number of large sites to see if anything changed since its last release that wasn't supposed to.
https://github.com/mkdocs/regressions/actions/runs/5592767284/jobs/10248820937#step:7:7770

The good thing is that I didn't see any other unwanted diffs in Markdown with this :)

And I'm running into these differences only now, because soon I will release MkDocs that finally un-pins the version of Markdown (and so will bring a lot of new users of the latest versions).

If you're planning to make a new release of this package, a release with these fixes soon would be really helpful :)

@waylan waylan added bug Bug report. extension Related to one or more of the included extensions. confirmed Confirmed bug report or approved feature request. labels Jul 20, 2023
waylan added a commit to waylan/markdown that referenced this issue Jul 20, 2023
waylan added a commit that referenced this issue Jul 20, 2023
@waylan
Copy link
Member

waylan commented Jul 20, 2023

For some background:

Thanks for the background. I was wondering. In any event, we should be able to do a new release soon. I expect to have some more free time than usual next week so I'll aim for then,

@waylan
Copy link
Member

waylan commented Jul 25, 2023

@oprypin just thought you would like to know that we released version 3.4.4 today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug report. confirmed Confirmed bug report or approved feature request. extension Related to one or more of the included extensions.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants