Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix integration between classwise wrapper and metric tracker #3004

Merged
merged 7 commits into from
Mar 13, 2025

Conversation

SkafteNicki
Copy link
Member

@SkafteNicki SkafteNicki commented Mar 12, 2025

What does this PR do?

Fixes #2994

Before submitting
  • Was this discussed/agreed via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure to update the docs?
  • Did you write any new necessary tests?
PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃


📚 Documentation preview 📚: https://torchmetrics--3004.org.readthedocs.build/en/3004/

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@SkafteNicki SkafteNicki added the bug / fix Something isn't working label Mar 12, 2025
@SkafteNicki SkafteNicki added this to the v1.6.x milestone Mar 12, 2025
@SkafteNicki SkafteNicki self-assigned this Mar 12, 2025
….com/Lightning-AI/torchmetrics into bugfix/tracker_classwise_integration
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 36%. Comparing base (d332ae3) to head (cc91d35).
Report is 2 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (d332ae3) and HEAD (cc91d35). Click for more details.

HEAD has 56 uploads less than BASE
Flag BASE (d332ae3) HEAD (cc91d35)
macOS 6 3
cpu 28 14
python3.12 6 3
torch2.6.0 2 1
python3.10 18 9
torch2.0.1 4 2
Windows 4 2
torch2.6.0+cpu 2 1
torch2.0.1+cpu 6 3
Linux 18 9
torch2.4.1+cpu 4 2
python3.11 2 1
torch2.3.1+cpu 2 1
torch2.5.0+cpu 4 2
torch2.1.2+cpu 2 1
python3.9 2 1
torch2.2.2+cpu 2 1
Additional details and impacted files
@@           Coverage Diff            @@
##           master   #3004     +/-   ##
========================================
- Coverage      69%     36%    -33%     
========================================
  Files         338     352     +14     
  Lines       19464   19647    +183     
========================================
- Hits        13486    7138   -6348     
- Misses       5978   12509   +6531     
🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ready label Mar 13, 2025
@Borda Borda merged commit 0423a2c into master Mar 13, 2025
60 checks passed
@Borda Borda deleted the bugfix/tracker_classwise_integration branch March 13, 2025 08:23
Borda pushed a commit that referenced this pull request Mar 13, 2025
* fix integration between wrapper
* add tests
* changelog
* fix typing

(cherry picked from commit 0423a2c)
Borda pushed a commit that referenced this pull request Mar 13, 2025
* fix integration between wrapper
* add tests
* changelog
* fix typing

(cherry picked from commit 0423a2c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug / fix Something isn't working ready
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve MetricTracker support for metrics nested in ClasswiseWrapper
2 participants