You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello,
I am not sure about changing something we used for long time and are satisfied with. @cako is currently away, once he is back at work he can give us his opinion as he introduced flake8 support to pylops.
I think ruff has a lot of potential, but I am hesitant port over to it right now for two reasons:
Ruff does not support pattern matching. The fix for this should be coming soon.
Ruff does not flag errors which are fixed by black. I understand we are using black as a pre-commit hook, but pre-commit hooks are not mandatory and can be bypassed. I would hate to be missing linting suggestions because someone at some point did not use black.
For those reasons I would rather wait until ruff becomes more mature before moving the whole project over to it. I am closing this issue as wontfix for now.
@mrava87 Ruff has made a lot of progress in this year. I've been using it almost exclusively for new projects. It's crazy fast! I think once they close these issues, we should think about migrating to it.
Use ruff instead of flake8
The text was updated successfully, but these errors were encountered: