Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tomlkit] Limit the maximum version of tomlkit #8633

Merged

Conversation

Pierre-Sassoulas
Copy link
Member

Type of Changes

Type
βœ“ πŸ› Bug fix

Description

Will require a real fix later

Refs #8632

@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.4 milestone Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #8633 (d400fe5) into main (5d82d7b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #8633   +/-   ##
=======================================
  Coverage   95.81%   95.81%           
=======================================
  Files         174      174           
  Lines       18321    18321           
=======================================
  Hits        17554    17554           
  Misses        767      767           

DudeNr33
DudeNr33 previously approved these changes Apr 28, 2023
Copy link
Collaborator

@DudeNr33 DudeNr33 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small remark, otherwise looks good!

doc/whatsnew/fragments/8632.bugfix Outdated Show resolved Hide resolved
Co-authored-by: Andreas Finkler <3929834+DudeNr33@users.noreply.github.com>
@DudeNr33 DudeNr33 merged commit a59f3d5 into pylint-dev:main Apr 28, 2023
24 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 28, 2023
@Pierre-Sassoulas Pierre-Sassoulas deleted the hotfix-crash-in-tomlkit-0.11.8 branch April 28, 2023 17:12
Pierre-Sassoulas added a commit that referenced this pull request Apr 28, 2023
(cherry picked from commit a59f3d5)

Co-authored-by: Pierre Sassoulas <pierre.sassoulas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported Crash πŸ’₯ A bug that makes pylint crash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants