Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/2.17.x] Added escaping of vertical bar character in annotation labels #8631

Merged

Conversation

DudeNr33
Copy link
Collaborator

Manual backport of #8610 according to the instructions:
#8610 (comment)

Resolved the merge conflicts locally.
Everything looks fine to me, but as I've never done a backport before I would be happy if someone could cross-check it!

@DudeNr33 DudeNr33 added Bug 🪲 pyreverse Related to pyreverse component python 3.10 labels Apr 27, 2023
@DudeNr33 DudeNr33 added this to the 2.17.4 milestone Apr 27, 2023
@DudeNr33 DudeNr33 self-assigned this Apr 27, 2023
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #8631 (a9afc15) into maintenance/2.17.x (e507a4d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           maintenance/2.17.x    #8631   +/-   ##
===================================================
  Coverage               95.56%   95.56%           
===================================================
  Files                     178      178           
  Lines                   18806    18810    +4     
===================================================
+ Hits                    17972    17976    +4     
  Misses                    834      834           
Impacted Files Coverage Δ
pylint/pyreverse/dot_printer.py 85.86% <100.00%> (+0.64%) ⬆️

Copy link
Member

@Pierre-Sassoulas Pierre-Sassoulas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for cherry-picking ! The pipeline fail because of #8632

@Pierre-Sassoulas Pierre-Sassoulas merged commit 4350c6f into maintenance/2.17.x Apr 27, 2023
26 of 27 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-8610-to-maintenance/2.17.x branch April 27, 2023 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug 🪲 pyreverse Related to pyreverse component python 3.10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants