Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport maintenance/2.17.x] Fix false positive for keyword-arg-before-vararg #8578

Merged

Conversation

github-actions[bot]
Copy link
Contributor

Backport 56fa5dc from #8571.

* Fix false positive for ``keyword-arg-before-vararg`` when a positional-only parameter with a default value precedes ``*args``.

Closes #8570

(cherry picked from commit 56fa5dc)
@Pierre-Sassoulas Pierre-Sassoulas added the False Positive 🦟 A message is emitted but nothing is wrong with the code label Apr 15, 2023
@Pierre-Sassoulas Pierre-Sassoulas added this to the 2.17.3 milestone Apr 15, 2023
@codecov
Copy link

codecov bot commented Apr 15, 2023

Codecov Report

Merging #8578 (aa2a64c) into maintenance/2.17.x (16fe498) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@                 Coverage Diff                 @@
##           maintenance/2.17.x    #8578   +/-   ##
===================================================
  Coverage               95.56%   95.56%           
===================================================
  Files                     178      178           
  Lines                   18800    18802    +2     
===================================================
+ Hits                    17966    17968    +2     
  Misses                    834      834           
Impacted Files Coverage Δ
pylint/checkers/typecheck.py 96.46% <100.00%> (+<0.01%) ⬆️

@Pierre-Sassoulas Pierre-Sassoulas merged commit ec96bdc into maintenance/2.17.x Apr 15, 2023
24 checks passed
@Pierre-Sassoulas Pierre-Sassoulas deleted the backport-8571-to-maintenance/2.17.x branch April 15, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
False Positive 🦟 A message is emitted but nothing is wrong with the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants