-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking βSign up for GitHubβ, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3.8+ asyncSetUp
to "defining-attr-methods" list
#8403
Add Python 3.8+ asyncSetUp
to "defining-attr-methods" list
#8403
Conversation
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you !
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #8403 +/- ##
==========================================
- Coverage 95.73% 95.73% -0.01%
==========================================
Files 174 174
Lines 18395 18392 -3
==========================================
- Hits 17610 17607 -3
Misses 785 785
|
(One check is still failing against Python 3.11, I guess this is unrelated to these changes as you've encountered the same error elsewhere lately) |
I don't know why the primer repeatedly fail. Could you try rebasing on upstream main so that the base commit is newer ? It could be that the cache from the common commit between your branch and the main branch is not available anymore. |
π€ According to the primer, this change has no effect on the checked open source code. π€π This comment was generated for commit 61ef33e |
(cherry picked from commit b312b9a)
Type of Changes
Description
This patch adds
unittest.IsolatedAsyncioTestCase
asynchronous "setUp" coroutine to the list of "defining-attr-methods", in order to silence "attribute-defined-outside-init" (W0201) false positive.Feel free to edit this PR as needed; I'm not sure how we should handle Python 3.8+ constraint here.
Thanks, bye π