port --testsuite to pytest #1174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asottile
commented
Jul 18, 2023
Comment on lines
-17
to
-18
| #: W292:1:36 noeol | ||
| # This line doesn't have a linefeed |
There was a problem hiding this comment.
there was a bug here! in python 3.8 this was reported 3 times. I didn't bother fixing the bug since it'll be "magically fixed" in python3.9+
I moved the test to its own file
FichteFoll
reviewed
Jul 19, 2023
Comment on lines
+29
to
+30
| sys.stdout = io.StringIO() | ||
| sys.stderr = io.StringIO() |
There was a problem hiding this comment.
FYI, pytest already captures stdout and provides a way to access it: https://docs.pytest.org/en/6.2.x/capture.html#accessing-captured-output-from-a-test-function
There was a problem hiding this comment.
yeah I'm a pytest core dev
There was a problem hiding this comment.
So, did you not use it for a certain reason or was it just (edit: not) within the scope of this PR?
There was a problem hiding this comment.
it's a larger refactor and this was already large enough
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.