Properly warn for E262 with non breaking whitespaces

[Pierre-Sassoulas]

Closes #1034

[asottile]

please use the escape sequence instead otherwise this code is very difficult to read

[Pierre-Sassoulas]

Done in 6975080

[asottile]

this shouldn't be needed now

[Pierre-Sassoulas]

61a8e66

[Pierre-Sassoulas]

I reverted the commit as we need the encoding for examples in docstrings.

[asottile]

the examples in the docstrings aren't readable, I'd prefer writing \xa0 there as well

[Pierre-Sassoulas]

Would you rather have no docstring exemples with NBSP or some hard to read one ? Because E262: x = x + 1 # \xa0Increment x does not trigger E262 (a real one will).

[asottile]

there's other examples where \t is used similarly, putting E262: x = x + 1 # \xa0Increment x (literally) into the docstring I believe gets the point across and is readable

[Pierre-Sassoulas]

There's a self test that check that the example are working apparently:

____________________________________________________________________________________ PycodestyleTestCase.test_selftest ____________________________________________________________________________________

self = <testsuite.test_all.PycodestyleTestCase testMethod=test_selftest>

    def test_selftest(self):
        fail_s, done_s = selftest(self._style.options)
        self.assertTrue(done_s, msg='tests not found')
>       self.assertFalse(fail_s, msg='%s failure(s)' % fail_s)
E       AssertionError: 1 is not false : 1 failure(s)

testsuite/test_all.py:33: AssertionError
------------------------------------------------------------------------------------------ Captured stdout call -------------------------------------------------------------------------------------------
pycodestyle.py: failed to find E262:
x = x + 1  # \xa0Increment x

[asottile]

if you remove the r on that docstring it should fix it

[Pierre-Sassoulas]

Done in fe23aa2

[asottile]

this constant isn't used anywhere but below -- inline it

[Pierre-Sassoulas]

41545a2

[Pierre-Sassoulas]

@asottile any idea why the 2.7 tests fails when using \xa0 ? They work if we do this 6939343

[asottile]

@asottile any idea why the 2.7 tests fails when using \xa0 ? They work if we do this 6939343

good question, I vote we just drop python 2.7 -- I'll put together a branch if there isn't one already

[sigmavirus24]

If you rebase @Pierre-Sassoulas your tests should pass now that we're not testing against 2.7

[Pierre-Sassoulas]

This is rebased/cleaned up ! Thank you for the review, and thank you for dropping python 2.7, not having to deal with that encoding issue is a relief 😄

[asottile]