-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be able to load a profile from an external package #604
Conversation
Should add a package to be able to write unit tests? |
bb51f25
to
af9a009
Compare
@Pierre-Sassoulas for me, it's ready to be reviewed, thanks :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a small nitpick, and it looks pretty good imo (I might use this for other packages). I think for this kind of big design decision a review by @carlio is required though.
Thanks @Pierre-Sassoulas |
All looks good to me :-) I'd suggest putting a |
Thanks for the merge :-) |
You could test it by using a git dependency instead of pypi, do |
Hi there, I got distracted, sorry about that. Prospector 1.10.0 is on PyPI now with this in it :-) |
Description
Add the possibility to use a profile shared throw a Python package.
Related Issue
Fix #459.
Motivation and Context
Be able to share a profile between different projects.
How Has This Been Tested?
.prospector.yaml
configuration file that uses this profile.prospector.yaml
file)Types of changes
Checklist: