Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pip install "isort[colors]" no longer installs colorama #2211

Closed
effigies opened this issue Dec 11, 2023 · 3 comments · Fixed by #2212
Closed

pip install "isort[colors]" no longer installs colorama #2211

effigies opened this issue Dec 11, 2023 · 3 comments · Fixed by #2212

Comments

@effigies
Copy link

From a CI job:

Run python -m pip install --upgrade flake8 black isort[colors]
Collecting flake8
  Downloading flake8-6.1.0-py2.py3-none-any.whl.metadata (3.8 kB)
Collecting black
  Downloading black-23.11.0-py3-none-any.whl.metadata (66 kB)
     ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 66.9/66.9 kB 3.8 MB/s eta 0:00:00
Collecting isort[colors]
  Downloading isort-5.13.1-py3-none-any.whl.metadata (12 kB)
Collecting mccabe<0.8.0,>=0.7.0 (from flake8)
  Downloading mccabe-0.7.0-py2.py3-none-any.whl (7.3 kB)
Collecting pycodestyle<2.12.0,>=2.11.0 (from flake8)
  Downloading pycodestyle-2.11.1-py2.py3-none-any.whl.metadata (4.5 kB)
Collecting pyflakes<3.2.0,>=3.1.0 (from flake8)
  Downloading pyflakes-3.1.0-py2.py3-none-any.whl.metadata (3.5 kB)
Collecting click>=8.0.0 (from black)
  Downloading click-8.1.7-py3-none-any.whl.metadata (3.0 kB)
Collecting mypy-extensions>=0.4.3 (from black)
  Downloading mypy_extensions-1.0.0-py3-none-any.whl (4.7 kB)
Collecting packaging>=22.0 (from black)
  Downloading packaging-23.2-py3-none-any.whl.metadata (3.2 kB)
Collecting pathspec>=0.9.0 (from black)
  Downloading pathspec-0.12.1-py3-none-any.whl.metadata (21 kB)
Collecting platformdirs>=2 (from black)
  Downloading platformdirs-4.1.0-py3-none-any.whl.metadata (11 kB)
Downloading flake8-6.1.0-py2.py3-none-any.whl (58 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 58.3/58.3 kB 7.6 MB/s eta 0:00:00
Downloading black-23.11.0-py3-none-any.whl (191 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 192.0/192.0 kB 8.3 MB/s eta 0:00:00
Downloading click-8.1.7-py3-none-any.whl (97 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 97.9/97.9 kB 7.4 MB/s eta 0:00:00
Downloading packaging-23.2-py3-none-any.whl (53 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 53.0/53.0 kB 7.6 MB/s eta 0:00:00
Downloading pathspec-0.12.1-py3-none-any.whl (31 kB)
Downloading platformdirs-4.1.0-py3-none-any.whl (17 kB)
Downloading pycodestyle-2.11.1-py2.py3-none-any.whl (31 kB)
Downloading pyflakes-3.1.0-py2.py3-none-any.whl (62 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 62.6/62.6 kB 8.8 MB/s eta 0:00:00
Downloading isort-5.13.1-py3-none-any.whl (92 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 92.3/92.3 kB 7.4 MB/s eta 0:00:00
Installing collected packages: pyflakes, pycodestyle, platformdirs, pathspec, packaging, mypy-extensions, mccabe, isort, click, flake8, black
Successfully installed black-23.11.0 click-8.1.7 flake8-6.1.0 isort-5.13.1 mccabe-0.7.0 mypy-extensions-1.0.0 packaging-23.2 pathspec-0.12.1 platformdirs-4.1.0 pycodestyle-2.11.1 pyflakes-3.1.0

Resulting in:

Run isort --diff --color --check tools/schemacode

Sorry, but to use --color (color_output) the colorama python package is required.

Reference: https://pypi.org/project/colorama/

You can either install it separately on your system or as the colors extra for isort. Ex: 

$ pip install isort[colors]

Error: Process completed with exit code 1.

Seems to be a result of #2207.

@effigies
Copy link
Author

Note that we're getting a pre-commit update from 5.12.0 to 5.13.1, so it may have a more complex cause.

@staticdev
Copy link
Collaborator

@effigies I think I found the problem #2212

staticdev added a commit that referenced this issue Dec 12, 2023
@effigies
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants