Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update plone profile: copy of black, plus three settings. #1926

Merged
merged 1 commit into from
May 11, 2022
Merged

Update plone profile: copy of black, plus three settings. #1926

merged 1 commit into from
May 11, 2022
+8 −6

Conversation

mauritsvanrees
Copy link
Contributor

Fixes #1925

The Plone-related tests pass, three others fail. Should be unrelated, or maybe a bad setup locally:

FAILED tests/unit/test_literal.py::test_value_assignment_list - isort.exceptions.FormattingPluginDoesNotExist: Specified formatting plugin of example does not exist.
FAILED tests/unit/test_ticketed_features.py::test_isort_supports_formatting_plugins_issue_1353 - isort.exceptions.FormattingPluginDoesNotExist: Specified formatting plugin of example does not exist.
FAILED tests/unit/test_ticketed_features.py::test_isort_literals_issue_1358 - isort.exceptions.FormattingPluginDoesNotExist: Specified formatting plugin of example does not exist.

Also, ./scripts/test.sh fails because some security updates need to be added, so poetry update needs to run, but that fails, see issue #1915.

@mauritsvanrees mauritsvanrees mentioned this pull request May 3, 2022
Closed
ale-rt
ale-rt approved these changes May 6, 2022
View reviewed changes
Copy link

@ale-rt ale-rt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jensens
Copy link

jensens commented May 11, 2022

LGTM, it reflects our community code formatting rules for Plone 6.

@ale-rt
Copy link

ale-rt commented May 11, 2022

FYI @timothycrosley ^

@timothycrosley timothycrosley merged commit 2cb757e into PyCQA:main May 11, 2022
@mauritsvanrees mauritsvanrees deleted the issue/1925 branch May 11, 2022 12:17
@wesleybl wesleybl mentioned this pull request Aug 5, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ale-rt ale-rt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update plone profile
4 participants
@mauritsvanrees @jensens @ale-rt @timothycrosley