Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add flake8 w/ bugbear to pre-commit config #427

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

r-downing
Copy link
Contributor

For #412

Just adds basic flake8 +bugbear check to pre-commit config

@r-downing
Copy link
Contributor Author

Also, I noticed that the pre-commit auto-updating is breaking the test-suites?

We could add a similar exclude: ^tests/b.* line to pre-commit for black and isort and to bypass the formatting and check for these specific files, since they depend on line and column numbers and contain examples of bad code

Copy link
Collaborator

@cooperlees cooperlees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will at least stop us failing our own checks that are released :)

@cooperlees cooperlees merged commit aabaf1d into PyCQA:main Nov 27, 2023
@jakkdl
Copy link
Contributor

jakkdl commented Dec 1, 2023

🎉

@r-downing r-downing deleted the flake8-on-precommit2 branch December 1, 2023 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants