Support ignoring blacklists by name #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This extends nosec parsing to enable blacklists to be ignored by their name, not just by id. There were 2 issues with the previous implementation: 1. The regex did not match numbers, which is needed for some names, such as md5. The code would only match "md" in this case. 2. The function that maps plugin names to ids only considered plugins but not blacklists. Both of these are now addressed. Closes PyCQA#988
costaparas
requested review from
ericwb,
lukehinds and
sigmavirus24
as code owners
The original code considered plugins, but not blacklists. Since the code now correctly considers both types of tests, the function and variables should be renamed to avoid confusion.
costaparas
force-pushed
the
feature/blacklists-ignorable-by-name
branch
from
05bd875
to
d24d179
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends nosec parsing to enable blacklists to be ignored by their name, not just by id.
There were 2 issues with the previous implementation:
Both of these are now addressed.
Closes #988