Fix brain dict regression #2204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
from
5da1e42
to
b23d74e
Compare
|
Put back as draft as this apparently breaks tests. |
|
@jacobtylerwalls I tried to implement your suggestion but with that I apparently run into other test failures. I could get pylint working again with: --- a/astroid/manager.py
+++ b/astroid/manager.py
@@ -66,6 +66,7 @@ class AstroidManager:
def __init__(self) -> None:
# NOTE: cache entries are added by the [re]builder
+ self.__dict__ = AstroidManager.brain
self.astroid_cache = AstroidManager.brain["astroid_cache"]
self._mod_file_cache = AstroidManager.brain["_mod_file_cache"]
self._failed_import_hooks = AstroidManager.brain["_failed_import_hooks"]At the moment I'm stuck as I don't know enough about astroid to continue here. |
|
Interesting. What happens if you revert the changes relating to the mutable values like |
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
2 times, most recently
from
0d68276
to
1b3452a
Compare
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
from
4bc4d37
to
9fb673e
Compare
jacobtylerwalls
previously approved these changes
Jun 7, 2023
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
from
9fb673e
to
5ddfecd
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
==========================================
+ Coverage 92.53% 92.68% +0.15%
==========================================
Files 94 94
Lines 10818 10830 +12
==========================================
+ Hits 10010 10038 +28
+ Misses 808 792 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
|
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
from
5ddfecd
to
167be8e
Compare
jacobtylerwalls
previously approved these changes
Jun 7, 2023
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
2 times, most recently
from
cc2ccfb
to
6ad6d2e
Compare
We get rid of the immutable instance attributes in AstroidManager, ensuring that these always mutate the global state instead of instance's. This fixes a regression introduced in commit bbcc58b. Fixes pylint-dev#2200
knedlsepp
force-pushed
the
fix-brain-dict-regression
branch
from
6ad6d2e
to
5effdf8
Compare
jacobtylerwalls
previously approved these changes
Jun 7, 2023
|
@jacobtylerwalls Do you want to add typing to these signatures? |
|
Nah, doesn't need to be done now. Doesn't provide much value anyway. |
|
The missing coverage is worth adding, though! |
for more information, see https://pre-commit.ci
jacobtylerwalls
pushed a commit
that referenced
this pull request
Jun 8, 2023
Fix regression resulting in ignored pylint settings We get rid of the immutable instance attributes in AstroidManager, ensuring that these always mutate the global state instead of instance's. This fixes a regression introduced in commit bbcc58b. Fixes #2200 (cherry picked from commit b08166b) Co-authored-by: Josef Kemetmüller <josef.kemetmueller@gmail.com>
|
Thank you! |
Pierre-Sassoulas
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Changes
This fixes issue #2200, which should fix pylint-dev/pylint#7433.
Description
Closes #2200